Re: Review Request: Fix hang in kcm_useraccount

> On Aug. 6, 2012, 6:09 p.m., Raphael Kubo da Costa wrote: > > How does this play with https://git.reviewboard.kde.org/r/104439 ? That review addresses a (different) case where chfn to produces a different output to what the kcm is expecting. Unfortunately I do not run either of those distros

Re: Review Request: Fix hang in kcm_useraccount

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/ --- (Updated Aug. 6, 2012, 5:03 p.m.) Review request for KDE Base Apps. Chan

Review Request: Make "New File -> Text File" create empty file

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105888/ --- Review request for KDE Base Apps. Description --- Currently TextFile.

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review17015 --- looking excellent now. just some style issues left. please wri

Re: Review Request: Allow symlink creation for kio protocols that support it

> On Aug. 3, 2012, 8:48 a.m., David Faure wrote: > > I'm not sure this makes sense. You drag-n-drop a symlink called "link" to a > > file called "target" from fish://myhost to your local $HOME, and you end up > > with a broken symlink, given that "target" is nowhere to be found? > > > > The lo

Re: Review Request: Allow symlink creation for kio protocols that support it

> On Aug. 3, 2012, 8:49 a.m., David Faure wrote: > > "Actually we need to test both source and destination to check if their > > protocols support symlink creation." > > > > Haha, if we're copying a symlink, then obviously the source protocol > > supports symlinks, otherwise it wouldn't be the

Re: Review Request: Allow symlink creation for kio protocols that support it

> On Aug. 3, 2012, 8:48 a.m., David Faure wrote: > > I'm not sure this makes sense. You drag-n-drop a symlink called "link" to a > > file called "target" from fish://myhost to your local $HOME, and you end up > > with a broken symlink, given that "target" is nowhere to be found? > > > > The lo

Re: Review Request: Fix Warning messages when closing About popup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105627/#review16993 --- This review has been submitted with commit 9aaa24814030041f514

Re: Review Request: Support for GRUB2 submenus

> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 232 > > > > > > can be inlined into the caller > On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdow

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 6, 2012, 6:29 p.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Fix hang in kcm_useraccount

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/#review16989 --- How does this play with https://git.reviewboard.kde.org/r/10443

Re: Review Request: Fix hang in kcm_useraccount

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/#review16985 --- kdepasswd/kcm/chfnprocess.cpp

Review Request: Fix hang in kcm_useraccount

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105895/ --- Review request for KDE Base Apps. Description --- When changing the u

Re: Review Request: Allow symlink creation for kio protocols that support it

> On Aug. 3, 2012, 8:49 a.m., David Faure wrote: > > "Actually we need to test both source and destination to check if their > > protocols support symlink creation." > > > > Haha, if we're copying a symlink, then obviously the source protocol > > supports symlinks, otherwise it wouldn't be the

Re: Review Request: Allow symlink creation for kio protocols that support it

> On Aug. 3, 2012, 8:48 a.m., David Faure wrote: > > I'm not sure this makes sense. You drag-n-drop a symlink called "link" to a > > file called "target" from fish://myhost to your local $HOME, and you end up > > with a broken symlink, given that "target" is nowhere to be found? > > > > The lo

Re: Review Request: Fix Warning messages when closing About popup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105627/#review16965 --- Ship it! Heh, well it's not like KWidgetItemDelegate is mainta

Re: Review Request: Support for GRUB2 submenus

> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 488 > > > > > > as you make assumptions about the list structure below anyway, you can > > just make the menus a stack (t

Re: Review Request: Support for GRUB2 submenus

> On Aug. 6, 2012, 6:26 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 488 > > > > > > as you make assumptions about the list structure below anyway, you can > > just make the menus a stack (t