Re: Review Request: Do not save window size from special (no toolbar) poup windows

2012-08-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105841/#review16843 --- How does this relate to the call to mainWindow->resetAutoS

Re: playground/games/picmi moved to KDE Review

2012-08-03 Thread Jakob Gruber
On 07/20/2012 11:53 AM, Jakob Gruber wrote: > Hi all, > > > I'd like to announce the move of Picmi to KDE Review [1] with the > intended destination being kdegames. Picmi has been in KDE Review for 2 weeks, and according to the application lifecycle the initial review period is now over. I have

Review Request: Do not save window size from special (no toolbar) poup windows

2012-08-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105841/ --- Review request for KDE Base Apps and David Faure. Description --- Now

Re: Review Request: Fix for stale permissions information in properties dialog

2012-08-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103555/ --- (Updated Aug. 3, 2012, 7:04 p.m.) Review request for kdelibs and David Fau

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/#review16839 --- This review has been submitted with commit 5caef5d84f1a90a8584

Re: Review Request: Fix for clipped security icon in Konqueror when favicon is now shown

2012-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105805/#review16840 --- This review has been submitted with commit 89b1c2deec05f73f2ea

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-08-03 Thread Dawit Alemayehu
> On Aug. 3, 2012, 9:09 a.m., David Faure wrote: > > Thanks for the additional testing, now the patch makes more sense overall. > > > > It's more "special cases" scattered around the code, but not much choice > > there, with the existing design. > > > > Please document what m_isPopupWindow mea

Re: Review Request: Add CamelCase wrapper for kcodecaction.h

2012-08-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105818/#review16836 --- This review has been submitted with commit ef3e34f3726dd1ab870

Re: Review Request: Allow symlink creation for kio protocols that support it

2012-08-03 Thread Lamarque Vieira Souza
> On Aug. 3, 2012, 8:49 a.m., David Faure wrote: > > "Actually we need to test both source and destination to check if their > > protocols support symlink creation." > > > > Haha, if we're copying a symlink, then obviously the source protocol > > supports symlinks, otherwise it wouldn't be the

Re: Review Request: Allow symlink creation for kio protocols that support it

2012-08-03 Thread Lamarque Vieira Souza
> On Aug. 3, 2012, 8:48 a.m., David Faure wrote: > > I'm not sure this makes sense. You drag-n-drop a symlink called "link" to a > > file called "target" from fish://myhost to your local $HOME, and you end up > > with a broken symlink, given that "target" is nowhere to be found? > > > > The lo

Re: C++11 requirement?

2012-08-03 Thread Ivan Čukić
> The service will not be built if the compiler doesn't support some C++11 > features. The build should not break, if it does, please report. P.S. I did accidentally broke the non-new-gcc build yesterday, it is fixed now. Forgot to run clang and gcc4.5 compilation before pushing. -- Cheerio, Iva

Re: C++11 requirement?

2012-08-03 Thread Ivan Cukic
> So, that surprised me, because it was not discussed at all here. There was a discussion regarding this. This is not abour Platform 4. The summary was: - kdelibs need to be compilable with old compilers (all that Qt supports obviously) - linux-specific parts can require gcc 4.5 (kwin, kactiviti

C++11 requirement?

2012-08-03 Thread Stephen Kelly
Hi there, I learned recently that central parts of KDE Platform 4 are depending on C++11 features: http://ivan.fomentgroup.org/blog/2012/08/02/module-giveaway-sessions-and- activities-updated/ Using C++11 features in central parts of KDE Platform 4 effectively means that a C++11 compiler is n

Re: Review Request: Fix for clipped security icon in Konqueror when favicon is now shown

2012-08-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105805/#review16818 --- Ship it! Ship It! - David Faure On July 31, 2012, 3:52 p.m.

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-08-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/#review16817 --- Ship it! Thanks for the additional testing, now the patch make

Re: Review Request: Allow symlink creation for kio protocols that support it

2012-08-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105831/#review16814 --- "Actually we need to test both source and destination to check

Re: Review Request: Allow symlink creation for kio protocols that support it

2012-08-03 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105831/#review16813 --- I'm not sure this makes sense. You drag-n-drop a symlink called