Review Request: Add CamelCase wrapper for kcodecaction.h

2012-08-01 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105818/ --- Review request for kdelibs. Description --- There is no CamelCase wra

Review Request: Add CamelCase wrapper for kcodecaction.h

2012-08-01 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105818/ --- Review request for kdelibs. Description --- There is no CamelCase wra

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Konstantinos Smanis
> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 485 > > > > > > why do you do that? the non-nested case should be just the simple > > solution of the general nested case

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Oswald Buddenhagen
> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 239 > > > > > > this implementation is very clever, but i wonder whether it wouldn't be > > better to do something more conve

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Konstantinos Smanis
> On Aug. 1, 2012, 11:49 a.m., Konstantinos Smanis wrote: > > Btw I see that they have bumped the version to 4.8.5 (no tag yet). Maybe we > > should drop the ksmserver part? It doesn't apply on the 4.9 branch. > > Lamarque Vieira Souza wrote: > We still need to port the part that deals with

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Lamarque Vieira Souza
> On Aug. 1, 2012, 11:49 a.m., Konstantinos Smanis wrote: > > Btw I see that they have bumped the version to 4.8.5 (no tag yet). Maybe we > > should drop the ksmserver part? It doesn't apply on the 4.9 branch. We still need to port the part that deals with submenu separator to ksmserver 4.9.x.

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16753 --- Btw I see that they have bumped the version to 4.8.5 (no tag ye

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated Aug. 1, 2012, 8:54 a.m.) Review request for KDE Runtime and Oswal

Re: Review Request: Support for GRUB2 submenus

2012-08-01 Thread Konstantinos Smanis
> On Aug. 1, 2012, 6:25 a.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > > > > > this function must come with a huge warning that strlen(after) must be > > at most strlen(before) - otherwise