Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16732 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16723 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Konstantinos Smanis
> On July 31, 2012, 7:17 p.m., Lamarque Vieira Souza wrote: > > kdm/backend/bootman.c, line 269 > > > > > > "const char *sep;" just declares a pointer called sep, it does not > > allocate memory to store any char

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16719 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Konstantinos Smanis
> On July 31, 2012, 6:39 p.m., Lamarque Vieira Souza wrote: > > kdm/backend/bootman.c, line 269 > > > > > > I think the memory for *sep has not been allocated yet at this point, > > so you should use something lik

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16717 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16710 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 31, 2012, 5:54 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

2012-07-31 Thread Konstantinos Smanis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16707 --- Argh, the last 2 diffs suck. Will update soon! - Konstantinos

Review Request: Fix for clipped security icon in Konqueror when favicon is now shown

2012-07-31 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105805/ --- Review request for KDE Base Apps. Description --- This patch is parti

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-31 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/ --- (Updated July 31, 2012, 3:32 p.m.) Review request for Dolphin, KDE Base Ap