Re: Review Request: properly pass the NOGUI flag

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105787/#review16629 --- Ship it! Mek seems to have added it in d37888c6c332ed431f1e08d

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 30, 2012, 12:06 a.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 10:53 p.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 8:30 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 7:09 p.m., Oswald Buddenhagen wrote: > > looks okayish. you should attack the bigger issues now. ;) Maybe tomorrow (unless I have a post-midnight coding mood). > On July 29, 2012, 7:09 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 287 > >

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16624 --- looks okayish. you should attack the bigger issues now. ;) kd

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 7:05 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 6:56 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 288 > > > > > > as this is a constant, you could use stringify() and literal > > concatenation - "foo" stringify(bar) "baz".

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16619 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 6:50 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 6:18 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 232 > > > > > > oh horrors :D > > please change that to an else-if and just decrement here. I had to try and sneak this :

Re: Review Request: Support for GRUB2 submenus

> On July 29, 2012, 6:21 p.m., Lamarque Vieira Souza wrote: > > kdm/backend/bootman.c, line 268 > > > > > > Maybe you should print a kWarning() saying that we only support up to 5 > > submenu levels. good point. b

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16616 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16614 --- kdm/backend/bootman.c

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 6:06 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 282 > > > > > > as you are putting the submenus into the selection list anyway, "menus" > > needs to be only a stack of inte

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > > > > > you don't seem to be actually counting opening braces, so detaching the > > two counts makes little sense. >

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 29, 2012, 11:58 a.m.) Review request for KDE Runtime and Osw

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > > > > > > you don't seem to be actually counting opening braces, so detaching the > > two counts makes little sense. >