Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread David Faure
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread Thomas Lübking
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread Dawit Alemayehu
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread Dawit Alemayehu
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread David Faure
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread Parker Coates
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread Dawit Alemayehu
> On July 27, 2012, 8:50 a.m., David Faure wrote: > > I like the idea, but why the non-editable combo? What happens when > > navigating, in that window? Doesn't the combo then start to be messed up > > (the code assuming that it is editable, has history items, has completion, > > etc.) ... esp

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/ --- (Updated July 27, 2012, 8:52 a.m.) Review request for Dolphin, KDE Base Ap

Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-27 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/#review16512 --- I like the idea, but why the non-editable combo? What happens w