Re: Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/ --- (Updated July 27, 2012, 1:23 a.m.) Review request for KDE Base Apps and Da

Review Request: Prevent Konqueror's address bar from being hidden by default

2012-07-26 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105749/ --- Review request for KDE Base Apps and David Faure. Description --- The

Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/#review16485 --- This review has been submitted with commit 2c01ca85fa7be70c0a2

Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/#review16484 --- This review has been submitted with commit 3b3cdcff2261a15881e

Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/#review16483 --- This review has been submitted with commit 5f4d36a338c48224cb8

Re: Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-26 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/#review16471 --- Ship it! Ship It! - Marco Martin On July 9, 2012, 12:27 p.m

Re: playground/games/picmi moved to KDE Review

2012-07-26 Thread Jakob Gruber
On 07/26/2012 05:43 AM, Andrius da Costa Ribas wrote: > add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with RC.exe > when I try to add a kde4_add_app_icon. > fatal error RC1106: invalid option: -EHsc > > any hint with that? Googling turns up www.cmake.org/pipermail/cmake/2008-June/

Re: playground/games/picmi moved to KDE Review

2012-07-26 Thread Patrick Spendrin
Am 26.07.2012 05:43, schrieb Andrius da Costa Ribas: > add_definitions(${KDE4_ENABLE_EXCEPTIONS}) seems to interfere with > RC.exe when I try to add a kde4_add_app_icon. > fatal error RC1106: invalid option: -EHsc > > any hint with that? probably this has to be set in a different way then, someth

Re: playground/games/picmi moved to KDE Review

2012-07-26 Thread Patrick Spendrin
Am 26.07.2012 05:30, schrieb Andrius da Costa Ribas: > Hello, > > In src/systemexception.h: > return m_msg.toStdString().c_str(); > ^ my Qt copy was built with no support to toStdString, please consider > changing it to: > return m_msg.toLatin1(); Nope, your Qt copy was build with stl support, th