Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Jakob Gruber
On 07/22/2012 07:10 PM, Albert Astals Cid wrote: > My comments: > * You think you could give it a somehow bigger initial size? It starts very > small the first time A default size of 700x560 is now set (I had it at at first 800x650 but tsdgeos reminded me about netbooks). > * Do you have a big

Re: Review Request: kjs: Implement JSON.parse

2012-07-22 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review16241 --- Ship it! Ship It! - Maks Orlovich On July 6, 2012, 7:11 p.m

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/#review16240 --- This review has been submitted with commit d1d0389a925654084f8

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-22 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/#review16239 --- This review has been submitted with commit 9a622c16d969a39571b

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-22 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/#review16236 --- Ship it! Sorry about the delay (I was away). I don't see any o

Re: Review Request: kjs: Mark Date Infinity as invalid

2012-07-22 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/#review16230 --- Ship it! Ship It! - Maks Orlovich On July 6, 2012, 6:30 p.m

Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Albert Astals Cid
El Divendres, 20 de juliol de 2012, a les 11:53:28, Jakob Gruber va escriure: > Hi all, > > > I'd like to announce the move of Picmi to KDE Review [1] with the > intended destination being kdegames. > > Picmi is a nonogram logic game [2] I've been working on for around two > years. It includes b

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-22 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/#review16206 --- Ship it! - David Faure On July 21, 2012, 2:40 p.m., Dawit Al

Re: playground/games/picmi moved to KDE Review

2012-07-22 Thread Jakob Gruber
On 07/21/2012 09:38 PM, Raphael Kubo da Costa wrote: > Jakob Gruber writes: > >> I've replaced all std::shared_pointers with QSharedPointers this morning >> and removed the -std=c++11 flag. > > I'm now getting a few errors and warnings when trying to build picmi > with g++ 4.2.1, 4.6.3 and clang 3