Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Raphael Kubo da Costa
Jakob Gruber writes: > I've replaced all std::shared_pointers with QSharedPointers this morning > and removed the -std=c++11 flag. I'm now getting a few errors and warnings when trying to build picmi with g++ 4.2.1, 4.6.3 and clang 3.1: some of them are related to -pedantic being used + Qt and k

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Jakob Gruber
On 07/21/2012 11:16 AM, Adriaan de Groot wrote: > On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote: >> One other question: three of the included levels are small pictograms of >> Disney characters up to 31x32 px in size. I'm not sure if that could be >> a legal issue? > > I'd suggest bein

Re: Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread Oswald Buddenhagen
On Fri, Jul 20, 2012 at 08:27:36PM +0200, Thomas Lübking wrote: > Am 20.07.2012, 20:18 Uhr, schrieb Martin Gräßlin : > >already on the system (to my knowledge hardly anything not running as root > >can be protected against an attacker with same user privs). > > You can establish secure IPC - i fran

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-21 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/ --- (Updated July 21, 2012, 2:40 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: Account for markup in KSqueezedLabel selection

2012-07-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105620/#review16176 --- This review has been submitted with commit 013376e9a962984e422

Re: Re: Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread Alex Fiestas
On Friday 20 July 2012 20:27:36 Thomas Lübking wrote: > I don't atm. *really* know how kwallet operates but on your claim the > question is what additional security can be gained by the extra password. None. As you said it will be as secure as KWallet if we decrypt a databse at login (using the u

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Adriaan de Groot
On Saturday, July 21, 2012 10:48:47 AM Jakob Gruber wrote: > One other question: three of the included levels are small pictograms of > Disney characters up to 31x32 px in size. I'm not sure if that could be > a legal issue? I'd suggest being on the safe side and dropping those: the characters (l

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Rolf Eike Beer
Am Samstag 21 Juli 2012, 10:48:47 schrieb Jakob Gruber: > On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote: > > Jakob Gruber writes: > >> Building with KDE trunk will require the patch from > >> http://lists.kde.org/?l=kde-games-devel&m=134201653803914&w=2. > > > > BTW, the "config.h" part of

Re: playground/games/picmi moved to KDE Review

2012-07-21 Thread Jakob Gruber
On 07/21/2012 12:02 AM, Raphael Kubo da Costa wrote: > Jakob Gruber writes: > >> Building with KDE trunk will require the patch from >> http://lists.kde.org/?l=kde-games-devel&m=134201653803914&w=2. > > BTW, the "config.h" part of the patch should go in regardless of the > rest, as config.h shou

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread Volker Krause
On Friday 20 July 2012 17:58:04 Martin Gräßlin wrote: > Hi all, > > the problems around review request #105628 and getting KWallet's Password > dialog properly raised above the window it is asking the password for just > triggered a thought process. > > The main problem here is that $service ask fo

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread Kevin Krammer
On Saturday, 2012-07-21, David Faure wrote: > On Friday 20 July 2012 20:35:24 David Edmundson wrote: > > With Akonadi - there's always a window, and they have a solution. > > I don't think that's true. > > On KDE startup, the mail dispatcher might want to send pending email, > or the calendar app

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-21 Thread David Faure
On Friday 20 July 2012 20:35:24 David Edmundson wrote: > With Akonadi - there's always a window, and they have a solution. I don't think that's true. On KDE startup, the mail dispatcher might want to send pending email, or the calendar applet starts akonadi and then the imap resources start the

Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/#review16174 --- dolphin/src/dolphinpart.cpp