Re: Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

2012-07-20 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/ --- (Updated July 20, 2012, 11:38 p.m.) Review request for KDE Base Apps. Ch

Re: KDE SC 4.10 Feature Plan Now Available

2012-07-20 Thread Ben Cooksley
On Sat, Jul 21, 2012 at 9:46 AM, Albert Astals Cid wrote: > El Dijous, 19 de juliol de 2012, a les 19:04:13, Allen Winter va escriure: >> Howdy, >> >> Please add your planned features for KDE SC 4.10 to this wiki: >> http://techbase.kde.org/Schedules/KDE4/4.10_Release_Schedule > > Wrong link, that

Re: Review Request: kjs: Implement Date.toJSON

2012-07-20 Thread Bernd Buschinski
> On July 20, 2012, 10:22 p.m., Rolf Eike Beer wrote: > > kjs/CommonIdentifiers.h, line 59 > > > > > > toJSON is already present and you add toISOString? Are you sure this is > > the right diff? yep, general toJSON

Re: Review Request: kjs: Implement Date.toJSON

2012-07-20 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105631/#review16171 --- kjs/CommonIdentifiers.h

Re: playground/games/picmi moved to KDE Review

2012-07-20 Thread Raphael Kubo da Costa
Jakob Gruber writes: > Building with KDE trunk will require the patch from > http://lists.kde.org/?l=kde-games-devel&m=134201653803914&w=2. BTW, the "config.h" part of the patch should go in regardless of the rest, as config.h should be the first header included by the source files anyway. I've

Re: KDE SC 4.10 Feature Plan Now Available

2012-07-20 Thread Albert Astals Cid
El Dijous, 19 de juliol de 2012, a les 19:04:13, Allen Winter va escriure: > Howdy, > > Please add your planned features for KDE SC 4.10 to this wiki: > http://techbase.kde.org/Schedules/KDE4/4.10_Release_Schedule Wrong link, that content should be in http://techbase.kde.org/Schedules/KDE4/4.10_

Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread David Edmundson
On Fri, Jul 20, 2012 at 7:46 PM, Martin Gräßlin wrote: > On Friday 20 July 2012 18:25:15 David Edmundson wrote: >> On Fri, Jul 20, 2012 at 4:58 PM, Martin Gräßlin wrote: >> > Hi all, >> > >> > the problems around review request #105628 and getting KWallet's Password >> > dialog properly raised ab

as usual...

2012-07-20 Thread Jos Poortvliet
Please, PLEASE make the feature list as complete as possible: http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan It is an immense help in writing the announcement of 4.9! /the promoteers signature.asc Description: This is a digitally signed message part.

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Kevin Krammer
On Friday, 2012-07-20, Martin Gräßlin wrote: > So here my idea: let's move the password dialog into the desktop shell. > Have it as a so-called "persistent" notification popping out of the panel > and be shown on top of all other windows till the user either dismisses it > or enters the password.

Review Request: kjs: Implement Date.toJSON

2012-07-20 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105631/ --- Review request for kdelibs. Description --- kjs: Implement Date.toJSO

Re: Review Request: kjs: Implement Date.toISOString

2012-07-20 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/ --- (Updated July 20, 2012, 6:53 p.m.) Review request for kdelibs. Changes -

Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Martin Gräßlin
On Friday 20 July 2012 18:25:15 David Edmundson wrote: > On Fri, Jul 20, 2012 at 4:58 PM, Martin Gräßlin wrote: > > Hi all, > > > > the problems around review request #105628 and getting KWallet's Password > > dialog properly raised above the window it is asking the password for just > > triggered

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Thomas Lübking
Am 20.07.2012, 19:25 Uhr, schrieb David Edmundson : This problem also applies to Authkit/Polkit prompts as well as Telepathy windows (from personal experience) and anything else dbus-activated. Dbus-activated apps being launched are (probably) going to be even more common in the future, and w

Re: Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Thomas Lübking
Am 20.07.2012, 20:18 Uhr, schrieb Martin Gräßlin : already on the system (to my knowledge hardly anything not running as root can be protected against an attacker with same user privs). You can establish secure IPC - i frankly thought that's what kwallet was meant to do. But it still nicel

playground/games/picmi moved to KDE Review

2012-07-20 Thread Jakob Gruber
Hi all, I'd like to announce the move of Picmi to KDE Review [1] with the intended destination being kdegames. Picmi is a nonogram logic game [2] I've been working on for around two years. It includes both a random mode (with low completion times as the goal) and 51 preset puzzles which turn int

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread David Edmundson
On Fri, Jul 20, 2012 at 4:58 PM, Martin Gräßlin wrote: > Hi all, > > the problems around review request #105628 and getting KWallet's Password > dialog properly raised above the window it is asking the password for just > triggered a thought process. > > The main problem here is that $service ask

Re: Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Martin Gräßlin
On Friday 20 July 2012 19:37:00 Thomas Lübking wrote: > no, see above. the password dialog is snake-oil. (given kwallet acts like > this) no it's not complete snake-oil. It does not protect against an attacker already on the system (to my knowledge hardly anything not running as root can be protect

Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Thomas Lübking
2012/7/20, Martin Gräßlin : > Once the wallet is open every running application can read each single > password. So does not sound very secure to me in the first place. a) no. b) ouch. c) if kwallet is not intended to be a secure container (i frankly don't really use it as such) using asymetric e

Re: Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Martin Gräßlin
On Friday 20 July 2012 18:48:47 Thomas Lübking wrote: > Like into the plasma-desktop process which shares memory with random > plasmoids of questionable source? > No. And I mean "no way". The wallet password dialog isn't very secure > anyway, but passing the password through plasma means to open it

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Thomas Lübking
2012/7/20, Martin Gräßlin : > The main problem here is that $service ask for a password through > $otherservice. This utterly fails because the $service is not linked > directly > to a window which the window manager would need to properly stack the > window. Yes. > Now if we think about it in

Re: RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread David Faure
On Friday 20 July 2012 17:58:04 Martin Gräßlin wrote: > Hi all, > > the problems around review request #105628 and getting KWallet's Password > dialog properly raised above the window it is asking the password for just > triggered a thought process. > > The main problem here is that $service ask

RFC: Moving KWallet Password dialog into Plasma

2012-07-20 Thread Martin Gräßlin
Hi all, the problems around review request #105628 and getting KWallet's Password dialog properly raised above the window it is asking the password for just triggered a thought process. The main problem here is that $service ask for a password through $otherservice. This utterly fails because the

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Martin Gräßlin
> On July 20, 2012, 2:15 p.m., Martin Gräßlin wrote: > > > > Allen Winter wrote: > So I don't know much about window managers and stuff.. what I want is to > make sure that no matter what the prompt dialog is in the user's face and > can't be dismissed. > > The worst case I've fou

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Thomas Lübking
> On July 20, 2012, 2:17 p.m., Thomas Lübking wrote: > > kwalletd/kwalletd.cpp, lines 353-359 > > > > > > What's the point of demanding attention when the very next step is to > > force the window to be active what

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Allen Winter
> On July 20, 2012, 2:17 p.m., Thomas Lübking wrote: > > kwalletd/kwalletd.cpp, lines 353-359 > > > > > > What's the point of demanding attention when the very next step is to > > force the window to be active what

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Allen Winter
> On July 20, 2012, 2:15 p.m., Martin Gräßlin wrote: > > So I don't know much about window managers and stuff.. what I want is to make sure that no matter what the prompt dialog is in the user's face and can't be dismissed. The worst case I've found is when the akonadi mail dispatcher needs t

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Thomas Lübking
> On July 20, 2012, 2:15 p.m., Martin Gräßlin wrote: > > kwalletd/kwalletd.cpp, line 361 > > > > > > from API docs: "The usage of forceActiveWindow() is meant only for > > pagers and similar tools, which represent

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/#review16155 --- The point is that one process (akonadi) shall be able to get th

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/#review16158 --- kwalletd/kwalletd.cpp

Re: Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/#review16156 --- Well, I already mentioned it on IRC, but what you do is not "ke

Review Request: KWallet Password Prompt Dialog In Your Face

2012-07-20 Thread Allen Winter
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105628/ --- Review request for KDE Runtime, David Faure and Fredrik Höglund. Descripti

Re: Review Request: [PATCH] Make kio_info produce valid HTML

2012-07-20 Thread Paul Walger
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105590/ --- (Updated July 19, 2012, 8:21 p.m.) Review request for KDE Runtime. Chang