Scope of kde-frameworks-devel and k-c-d mailing lists

Hi, I am having this question: where should the frameworks review requests go? There was a long discussion back then. Some people preferred the establishment of kde-frameworks-devel, some did not. It was created in the end. Now, Albert's patches keep coming in, but it can happen with everybody el

Review Request: Only show the "Find File" action for local URL in Dolphin's KPart

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105607/ --- Review request for KDE Base Apps. Description --- The attached patch

Re: Review Request: [PATCH] Make kio_info produce valid HTML

> On July 17, 2012, 2:35 a.m., Michael Pyne wrote: > > I think the current best-practice for HTML is a doctype of (and I'm not > > kidding) , which also prevents requiring a manual annotation > > of text/css later in the style sheets. However these changes (except the > > question of the missi

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > ksmserver/shutdowndlg.cpp, line 477 > > > > > > no way. the backend should directly communicate the hierarchy > > separator. also to ksmserver (this is

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > tired or not ... Please check my replies. I will update the diff tomorrow. > On July 17, 2012, 10:23 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 231 > >

Review Request: Port K_GLOBAL_STATIC in kdecore to Q_GLOBAL_STATIC

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105603/ --- Review request for kdelibs and David Faure. Description --- There's t

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 17, 2012, 10 p.m.) Review request for KDE Runtime and Oswald

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 9:02 p.m., Oswald Buddenhagen wrote: > > kdm/backend/bootman.c, line 280 > > > > > > i have a deep dislike for the separator being just ">" - it's weirdness > > waiting to happen. use " >> " or

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/ --- (Updated July 17, 2012, 9:23 p.m.) Review request for KDE Runtime and Oswa

Re: Review Request: Add submenu support to QML shutdown dialog.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16022 --- I forgot to mention that the submenus should only be created if

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 5:33 p.m., Lamarque Vieira Souza wrote: > > Ship It! Should I commit this? The KDM maintainer hasn't replied yet. Plus, will the 4.8 branch get the fix eventually? Noone else has commented... - Konstantinos --- This

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16042 --- tired or not ... kdm/backend/bootman.c

Re: Review Request: Add submenu support to QML shutdown dialog.

> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Add submenu support to QML shutdown dialog.

> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16037 --- one profound concern and some style nitpicks. i didn't look at

Re: Review Request: Add submenu support to QML shutdown dialog.

> On July 17, 2012, 6:19 p.m., Konstantinos Smanis wrote: > > I forgot to mention that the submenus should only be created if Grub2 or > > Burg is the selected Boot Manager in KDM. Other bootloaders (grub, lilo) > > should still be able to use '>' in the menu titles without creating > > submen

Re: Review Request: Support for GRUB2 submenus

> On July 17, 2012, 5:33 p.m., Lamarque Vieira Souza wrote: > > Ship It! > > Konstantinos Smanis wrote: > Should I commit this? The KDM maintainer hasn't replied yet. Plus, will > the 4.8 branch get the fix eventually? Noone else has commented... I am giving my oppinion about the patch (sh

Re: Review Request: Do not leave dangling pointers in KToolbar when xml clients die

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105399/#review16023 --- This review has been submitted with commit 776098aae397b499a95

Re: Review Request: Add submenu support to QML shutdown dialog.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16019 --- This review has been submitted with commit 7884098c74837db178a

Re: Review Request: Add submenu support to QML shutdown dialog.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105568/#review16018 --- This review has been submitted with commit 0e325a61a57ff85f15b

Re: Review Request: Support for GRUB2 submenus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105563/#review16017 --- Ship it! Ship It! - Lamarque Vieira Souza On July 14, 2012,

Re: Review Request: [PATCH] Make kio_info produce valid HTML

> On July 17, 2012, 2:35 a.m., Michael Pyne wrote: > > I think the current best-practice for HTML is a doctype of (and I'm not > > kidding) , which also prevents requiring a manual annotation > > of text/css later in the style sheets. However these changes (except the > > question of the missi