Re: Review Request: KHBox cleanup in frameworks

2012-07-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105531/#review15762 --- This review has been submitted with commit 7109bcf03e342e00635

Re: Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

2012-07-12 Thread Rolf Eike Beer
Am Donnerstag, 12. Juli 2012, 16:15:53 schrieb David Faure: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105395/#review15734 > --

Re: Review Request: KHBox cleanup in frameworks

2012-07-12 Thread David Faure
> On July 12, 2012, 10:20 p.m., Christoph Feck wrote: > > kde3support/kdeui/k3listviewsearchline.cpp, line 537 > > > > > > Do not set fixed spacing, let the style figure it out. > > Albert Astals Cid wrote: > S

Re: Review Request: KHBox cleanup in frameworks

2012-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105531/#review15756 --- kde3support/kdeui/k3listviewsearchline.h

Re: Review Request: KHBox cleanup in frameworks

2012-07-12 Thread Albert Astals Cid
> On July 12, 2012, 10:20 p.m., Christoph Feck wrote: > > kde3support/kdeui/k3listviewsearchline.cpp, line 537 > > > > > > Do not set fixed spacing, let the style figure it out. Sorry but no, i'm not doing that, i'

Re: Review Request: KHBox cleanup in frameworks

2012-07-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105531/#review15753 --- kde3support/kdeui/k3listviewsearchline.cpp

Review Request: KHBox cleanup in frameworks

2012-07-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105531/ --- Review request for kdelibs and David Faure. Description --- Kill the

Re: more information in backtraces

2012-07-12 Thread David Faure
On Thursday 12 July 2012 19:37:16 Dominik Haumann wrote: > On Thursday, 12. July 2012 18:13:22 David Faure wrote: > > On Thursday 05 July 2012 15:39:33 Dominik Haumann wrote: > > > Here, startPos is a Cursor, but we cannot see its values. > > > > > > It would help tremendously sometimes to know th

Re: more information in backtraces

2012-07-12 Thread Dominik Haumann
On Thursday, 12. July 2012 18:13:22 David Faure wrote: > On Thursday 05 July 2012 15:39:33 Dominik Haumann wrote: > > Here, startPos is a Cursor, but we cannot see its values. > > > > It would help tremendously sometimes to know the line/column values. So > > having "startPos=(4, 2)" instead of "s

Re: Review Request: fix kio_activities cannot handle utf8 file name/path

2012-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105222/#review15736 --- workspace/kio/kio_activities.cpp

Re: Review Request: Allow usage of detailedsorry and detailederror in kdialog

2012-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105304/#review15735 --- Ship it! Looks good. For master only, though, given feature+me

Re: Review Request: konqueror shall allow to click a mailto: link without showing a (...this URL is untrusted...) confirmation dialog

2012-07-12 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105395/#review15734 --- Ship it! Looks good. I'm curious as to why this wasn't necessa

Re: more information in backtraces

2012-07-12 Thread David Faure
On Thursday 05 July 2012 15:39:33 Dominik Haumann wrote: > Here, startPos is a Cursor, but we cannot see its values. > > It would help tremendously sometimes to know the line/column values. So > having "startPos=(4, 2)" instead of "startPos=...". > > Is there any way to provide this feature to ge

Re: Review Request: kde-workspace KDE/4.9 broken

2012-07-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105522/#review15724 --- Ship it! Ship It! - Martin Gräßlin On July 12, 2012, 7:57 a

Review Request: kde-workspace KDE/4.9 broken

2012-07-12 Thread Guy Maurel
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105522/ --- Review request for kdelibs, Thomas Lübking and Martin Gräßlin. Description

Re: KCategorizedView bug?

2012-07-12 Thread Percy Camilo Triveño Aucahuasi
Hi Andreas, thanks, you were right, I already update the bug report[1]: - Attached the test case and its backtrace (two text files) - Append a comment about another test case ( is the same of this paste http://paste.kde.org/516338/ ) Regards, Percy https://bugs.kde.org/show_bug.cgi?id=303228

Re: KCategorizedView bug?

2012-07-12 Thread Andreas Pakulat
Hi, I can't help you with the use of the class, but you should improve the bugreport a bit. First of all, don't use paste's, either attach files to the bugreport or put the code and backtrace inline. The paste's may be deleted and then the bugreport is useless. The other thing I noticed is that t