Does KDE Desktop want a full-width mouse/pointer Button State mask?

2012-07-10 Thread Rick Stockton
It's awfully late for an API change to Qt5, but this would be an awkward Backward Compatibility problem to attempt in later Qt5 Releases: Should Qt5 present a 32-bit Button State mask? ** Background ** As you all remember, I added "more mouse buttons" for MouseButtonPress and MouseButtonRelea

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/#review15655 --- This review has been submitted with commit 92239b1e3f5d771325b

Re: Review Request: Move KdepimLibs dependency to DrKonqi

2012-07-10 Thread Michael Palimaka
> On July 3, 2012, 12:07 p.m., Aurélien Gâteau wrote: > > Was this actually asked by packagers? I am no expert, but the feedback I > > had from a Debian packager working on CMake projects was that he preferred > > to have all dependencies listed in the top-level CMakeLists.txt. > > > > The rea

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-10 Thread David Faure
> On July 1, 2012, 9:14 a.m., David Faure wrote: > > Great work! > > > > I noticed a few things though: > > > > * in your initial analysis, you said KEncodingDetector had code to detect > > the encoding from the html/xml and http headers. Is this functionality lost > > during this port, in kh

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/#review15635 --- Ship it! Don't forget to move the old class to khtml, and the

Re: Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread Martin Gräßlin
On Tuesday 10 July 2012 18:12:03 Thomas Lübking wrote: > Am 10.07.2012, 17:38 Uhr, schrieb guy-kde : > > Hello Thomas! > > Hi Guy and everyone else =) > > >> There's iirc somewhere a config key to build kwin w/o activity > >> support - try "ccmake" > >> > > I found in CMakeCache.txt: > > //Enab

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread Thomas Lübking
Am 10.07.2012, 17:38 Uhr, schrieb guy-kde : Hello Thomas! Hi Guy and everyone else =) There's iirc somewhere a config key to build kwin w/o activity support - try "ccmake" I found in CMakeCache.txt: //Enable building of KWin with kactivities support KWIN_BUILD_ACTIVITIES:BOOL=ON Is it

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread guy-kde
Hello Thomas! On Tue, 10 Jul 2012 15:09:40 +0200, Thomas Lübking wrote: Am 10.07.2012, 14:36 Uhr, schrieb guy-kde : I use the default values at ccmake, with shows me: KACTIVITIES_INCLUDE_DIRS /usr/local/include;usr/localinclude/KDE KActivities_DIR/usr/local/lib/cmake/KActivi

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread Thomas Lübking
Am 10.07.2012, 14:36 Uhr, schrieb guy-kde : I use the default values at ccmake, with shows me: KACTIVITIES_INCLUDE_DIRS /usr/local/include;usr/localinclude/KDE KActivities_DIR/usr/local/lib/cmake/KActivities There's iirc somewhere a config key to build kwin w/o activity suppor

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread guy-kde
Hallo Thomas! On Tue, 10 Jul 2012 12:46:34 +0200, Thomas Lübking wrote: are you building with disabled activities? I use the default values at ccmake, with shows me: KACTIVITIES_INCLUDE_DIRS /usr/local/include;usr/localinclude/KDE KActivities_DIR/usr/local/lib/cmake/KActivities

Re: Review Request: Optical disk icon for mounted ISO files

2012-07-10 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105502/#review15606 --- Ship it! Ship It! - Lukáš Tinkl On July 10, 2012, 11:31 a.m

Re: Review Request: Optical disk icon for mounted ISO files

2012-07-10 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105502/#review15605 --- Minus the whitespace changes, it looks good :) - Lukáš Tinkl

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread Thomas Lübking
are you building with disabled activities? 2012/7/10, guy-kde : > Hello Martin! > > On Tue, 10 Jul 2012 11:42:23 +0200, Martin Gräßlin > wrote: >> Am 10.07.2012 11:20, schrieb guy-kde: >>> make[2]: *** >>> [kwin/CMakeFiles/kdeinit_kwin.dir/kdeinit_kwin_automoc.o] Error 1 >>> make[1]: *** [kwin

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread guy-kde
Hello Martin! On Tue, 10 Jul 2012 11:42:23 +0200, Martin Gräßlin wrote: Am 10.07.2012 11:20, schrieb guy-kde: make[2]: *** [kwin/CMakeFiles/kdeinit_kwin.dir/kdeinit_kwin_automoc.o] Error 1 make[1]: *** [kwin/CMakeFiles/kdeinit_kwin.dir/all] Error 2 What can you help here? Nothing, that's a

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread Martin Gräßlin
Am 10.07.2012 11:20, schrieb guy-kde: make[2]: *** [kwin/CMakeFiles/kdeinit_kwin.dir/kdeinit_kwin_automoc.o] Error 1 make[1]: *** [kwin/CMakeFiles/kdeinit_kwin.dir/all] Error 2 What can you help here? Nothing, that's a compile error and seems to be pretty much independent of what happened to th

Re: kde-workspace KDE/4.9 broken

2012-07-10 Thread guy-kde
Hello! On Mon, 9 Jul 2012 19:27:32 -0300, Nicolás Alvarez wrote: 2012/7/9 Martin Klapetek : On Mon, Jul 9, 2012 at 10:55 PM, Albert Astals Cid wrote: Someone merged master to KDE/4.9, no clue if anyone is working on fixing it, but just thought you'd want to know KDE/4.9 is broken, you pr