Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-08 Thread Hui Ni
> On July 1, 2012, 9:14 a.m., David Faure wrote: > > Great work! > > > > I noticed a few things though: > > > > * in your initial analysis, you said KEncodingDetector had code to detect > > the encoding from the html/xml and http headers. Is this functionality lost > > during this port, in kh

Re: Review Request: remove KEncodingDetector from tier1/kcodecs

2012-07-08 Thread Hui Ni
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105392/ --- (Updated July 9, 2012, 6:27 a.m.) Review request for kdelibs, Kevin Ottens

Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-08 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/ --- Review request for KDE Runtime, Ivan Čukić and George Kiagiadakis. Descrip

Review Request: DrKonqi should report the crashes of kactivitymanagerd to the kactivities product in BKO

2012-07-08 Thread Jekyll Wu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105483/ --- Review request for KDE Runtime, Ivan Čukić and George Kiagiadakis. Descrip

Re: Review Request: Do not use user selected default browser to open XML files

2012-07-08 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105476/#review15546 --- This review has been submitted with commit d4af904d455c8348d12

Re: Review Request: Do not use user selected default browser to open XML files

2012-07-08 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105476/#review15536 --- kio/kio/krun.cpp