Re: Question about the shutdown dialog's reboot list implementation

2012-07-06 Thread Lamarque V. Souza
Em Friday 06 July 2012, Konstantinos Smanis escreveu: > On Sat, Jul 7, 2012 at 1:02 AM, Lamarque V. Souza wrote: > > Em Friday 06 July 2012, Konstantinos Smanis escreveu: > >> Hi, > > > > Hi, > > > >> I am working on a patch for bug #297209 > >> > >> (https://bugs.kde.org/show_bug.cgi?id=297209

Re: Question about the shutdown dialog's reboot list implementation

2012-07-06 Thread Lamarque V. Souza
Em Friday 06 July 2012, Konstantinos Smanis escreveu: > Hi, Hi, > I am working on a patch for bug #297209 > (https://bugs.kde.org/show_bug.cgi?id=297209) and couldn't help but > notice that since the Shutdown Dialog was QMLified, the code that > shows the reboot list (when long-clicking

Re: Review Request: More kio_sftp login related fixes

2012-07-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104642/#review15480 --- This review has been submitted with commit 51d580a019c67a7bf67

khtml/kmultipart/kmultipart.cpp uses wrong signal

2012-07-06 Thread Martin Koller
Hi, for this trivial bugfix I'd rather not go through reviewboard: Error: Object::connect: No such signal KHTMLPartBrowserExtension::openURLNotify() Object::connect: (sender name: 'KHTMLBrowserExtension') Object::connect: No such signal KHTMLPartBrowserExtension::setLocationBarURL(QString) O

Question about the shutdown dialog's reboot list implementation

2012-07-06 Thread Konstantinos Smanis
Hi, I am working on a patch for bug #297209 (https://bugs.kde.org/show_bug.cgi?id=297209) and couldn't help but notice that since the Shutdown Dialog was QMLified, the code that shows the reboot list (when long-clicking the Reboot button) has been moved in the QML code of the theme (http://lxr.kde

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 6, 2012, 7:11 p.m.) Review request for kdelibs. Descriptio

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Bernd Buschinski
> On July 6, 2012, 3:12 p.m., Maks Orlovich wrote: > > kjs/jsonlexer.cpp, line 309 > > > > > > What about two commas in a row? propAdded handles this (tested), we will hit the TokComma case 2 times in a row case

Re: Review Request: kjs: Mark Date Infinity as invalid

2012-07-06 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/ --- (Updated July 6, 2012, 6:30 p.m.) Review request for kdelibs. Changes --

Re: Review Request: kjs: Implement Date.toISOString

2012-07-06 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/ --- (Updated July 6, 2012, 5:47 p.m.) Review request for kdelibs. Changes --

Re: Review Request: kjs: Implement JSON.parse

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review15462 --- kjs/jsonlexer.cpp

Re: Review Request: kjs: Use toPrimitive in Array.join to get the correct String

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105391/#review15461 --- Ship it! kjs/array_object.cpp

Re: Review Request: kjs: Range needs a prototype

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105388/#review15460 --- Ship it! Ship It! - Maks Orlovich On June 29, 2012, 6:06 p.

Re: Review Request: kjs: Implement Date.toISOString

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105386/#review15459 --- kjs/date_object.cpp

Re: Review Request: kjs: Mark Date Infinity as invalid

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105387/#review15458 --- kjs/date_object.cpp

Re: Review Request: kjs: FunctionObject prototype attribute should be [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: false

2012-07-06 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105122/#review15457 --- Ship it! Ship It! - Maks Orlovich On June 18, 2012, 10:23 p

Re: Compiler version

2012-07-06 Thread David Jarvie
On Monday 02 July 2012 09:09:53 Ivan Cukic wrote: > > > > Debian Stable (Squeeze) is also 4.5 by default. > > > > Debian Stable (Squeeze) is 4.4.5 by default, with GCC 4.3.5 being > > provided too. > > Yes, that is the reason I excluded Debian from the distros to watch in this > case. > > Debi