Re: Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/#review15442 --- This review has been submitted with commit 14d6bf6153a228468b0

Re: Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Dan Vratil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/ --- (Updated July 5, 2012, 6:07 p.m.) Review request for kdelibs. Descriptio

Re: Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/#review15441 --- This review has been submitted with commit 4acf3b30718eabf000d

Re: Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Christoph Feck
> On July 5, 2012, 7:53 p.m., Christoph Feck wrote: > > ... to 4.9 branch, not master. - Christoph --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/#review15439

Re: Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/#review15439 --- Ship it! kdeui/widgets/kdatetable.cpp

Re: Review Request: fix exports using Q_DECL_EXPORT

2012-07-05 Thread Thiago Macieira
On quinta-feira, 5 de julho de 2012 13.40.48, Stephen Kelly wrote: > --- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105452/#review15424 > ---

Re: more information in backtraces

2012-07-05 Thread Andreas Pakulat
Hi, On Thu, Jul 5, 2012 at 4:14 PM, Dominik Haumann wrote: > On Thursday, July 05, 2012 03:56:16 PM Andreas Pakulat wrote: > > On Thu, Jul 5, 2012 at 3:39 PM, Dominik Haumann > wrote: > > > Is there any way to provide this feature to get better backtraces by > > > default in Dr. Konqi? > > > >

Re: Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/#review15425 --- Hm, wouldn't it be simpler to not use a pointer, but store the

Re: more information in backtraces

2012-07-05 Thread Dominik Haumann
On Thursday, July 05, 2012 03:56:16 PM Andreas Pakulat wrote: > On Thu, Jul 5, 2012 at 3:39 PM, Dominik Haumann wrote: > > Is there any way to provide this feature to get better backtraces by > > default in Dr. Konqi? > > It might work with gdb's pretty-printers, but dr. konqi needs to load them

Re: more information in backtraces

2012-07-05 Thread Andreas Pakulat
Hi, On Thu, Jul 5, 2012 at 3:57 PM, Christoph Feck wrote: > On Thursday 05 July 2012 15:39:33 Dominik Haumann wrote: > > Hi, > > > > in Kate, we have a (virtual) Cursor class: > > > > class Cursor > > { > > // public functions > > > > private: > > int m_line; > > int m_column > > };

Re: more information in backtraces

2012-07-05 Thread Christoph Feck
On Thursday 05 July 2012 15:39:33 Dominik Haumann wrote: > Hi, > > in Kate, we have a (virtual) Cursor class: > > class Cursor > { > // public functions > > private: > int m_line; > int m_column > }; > > Unfortunately, in backtraces by Dr. Konqi we only get: > #11 0x7f1c85128b2a

Re: more information in backtraces

2012-07-05 Thread Andreas Pakulat
Hi, On Thu, Jul 5, 2012 at 3:39 PM, Dominik Haumann wrote: > Hi, > > in Kate, we have a (virtual) Cursor class: > > class Cursor > { > // public functions > > private: > int m_line; > int m_column > }; > > Unfortunately, in backtraces by Dr. Konqi we only get: > #11 0x7f1c85128b2

more information in backtraces

2012-07-05 Thread Dominik Haumann
Hi, in Kate, we have a (virtual) Cursor class: class Cursor { // public functions private: int m_line; int m_column }; Unfortunately, in backtraces by Dr. Konqi we only get: #11 0x7f1c85128b2a in KateLayoutCache::updateViewCache (this=0x54db630, startPos=..., newViewLineCount=3

Re: Review Request: fix exports using Q_DECL_EXPORT

2012-07-05 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105452/#review15424 --- I disagree. I think the best solution is to have a copy of the

Re: KDE/4.8.x is gone

2012-07-05 Thread Albert Astals Cid
El Dijous, 5 de juliol de 2012, a les 14:24:44, Felix Geyer va escriure: > On 02.07.2012 18:01, Albert Astals Cid wrote: > > After talking with David and Vishesh we decided to kill the KDE/4.8.x and > > bring its "improvements" to work with the old sopranos to KDE/4.8 > > > > So in summary: > > K

Re: Review Request: fix exports using Q_DECL_EXPORT

2012-07-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105452/#review15422 --- Ship it! I think this is the correct solution, i.e. the "for n

Review Request: fix exports using Q_DECL_EXPORT

2012-07-05 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105452/ --- Review request for kdelibs, Stephen Kelly, David Faure, and Alexander Neundo

Re: Review Request: kjs: Implement JSON.parse

2012-07-05 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 5, 2012, 12:50 p.m.) Review request for kdelibs. Changes -

Re: Review Request: kjs: Implement JSON.parse

2012-07-05 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/ --- (Updated July 5, 2012, 12:35 p.m.) Review request for kdelibs. Descripti

Review Request: Fix a memory leak in KDateTable

2012-07-05 Thread Dan Vratil
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105451/ --- Review request for kdelibs. Description --- KDateTablePrivate::DatePa

Re: KDE/4.8.x is gone

2012-07-05 Thread Felix Geyer
On 02.07.2012 18:01, Albert Astals Cid wrote: > After talking with David and Vishesh we decided to kill the KDE/4.8.x and > bring its "improvements" to work with the old sopranos to KDE/4.8 > > So in summary: > KDE/4.9 is where 4.9 bugfixing happens, needs soprano 2.8 > KDE/4.8 is where 4.8 bug