Re: Review request: moving libkgoogle to extragear

2012-05-26 Thread John Layt
On Saturday 26 May 2012 00:47:04 Dan Vratil wrote: > Hi, > > LibKGoogle is a new optional dependency of kdepim-runtime. It's used by the > new Akonadi Google resources. > > It's now in kdereview [0] and I'd like to move it to extragear, so I'm > asking for a review on the library. > > Thanks >

Re: Review Request: kjs: Implement JSON.stringify

2012-05-26 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105057/#review14178 --- You forgot to change kjs/tests/ecmatest_broken_* kjs/json_obj

Re: Review Request: kjs: Implement JSON.parse

2012-05-26 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105056/#review14177 --- You forgot to change kjs/tests/ecmatest_broken_* - Rolf Eike B

Re: Review request: moving libkgoogle to extragear

2012-05-26 Thread Raphael Kubo da Costa
Dan Vratil writes: > Hi, > > LibKGoogle is a new optional dependency of kdepim-runtime. It's used by the > new Akonadi Google resources. > > It's now in kdereview [0] and I'd like to move it to extragear, so I'm asking > for a review on the library. One thing I have noticed is that libkgoogle se

Re: QtScript considered dangerous

2012-05-26 Thread Milian Wolff
On Thursday 24 May 2012 12:57:14 David Faure wrote: > On Thursday 24 May 2012 10:59:21 Dominik Haumann wrote: > > they said they will probably not spent the considerable amount of time > > in updating the archaic jsc checkout used in QtScript. > > What about the solution of updating the JSC in QtS

Re: QtScript considered dangerous

2012-05-26 Thread Milian Wolff
On Thursday 24 May 2012 11:28:41 Thomas Friedrichsmeier wrote: > -- Note: Reposting to follow Dominik's example of CCing kde-core-devel -- > > Hi, > > On Wednesday 23 May 2012, Milian Wolff wrote: > > We have port Kate away from QtScript. > > I'm not sure, whether this is a serious suggestion, o

Re: QtScript considered dangerous

2012-05-26 Thread Milian Wolff
On Thursday 24 May 2012 10:59:21 Dominik Haumann wrote: > Hi Milian, Hey Dominik, sorry for the long pause. Answers inline below. > CC: kde-core-devel, as this is really a tough issue... > > there are other applications like Kile that heavily use QtScript for > scripting as well, so porting away

Re: QtScript considered dangerous

2012-05-26 Thread Stephen Kelly
Dominik Haumann wrote: > On Friday, 25. May 2012 21:42:50 Stephen Kelly wrote: >> Christoph Cullmann wrote: >> > Still, a fix for QtScript would be the nicest solution or a port to the >> > "new" engine provided in Qt5, as I understood, there QtScript is anyway >> > "deprecated" in favour of the V

Re: Review request: moving libkgoogle to extragear

2012-05-26 Thread Aaron J. Seigo
On Saturday, May 26, 2012 00:47:04 Dan Vratil wrote: > Hi, > > LibKGoogle is a new optional dependency of kdepim-runtime. It's used by the > new Akonadi Google resources. > > It's now in kdereview [0] and I'd like to move it to extragear, so I'm > asking for a review on the library. i haven't lo

Re: QtScript considered dangerous

2012-05-26 Thread Dominik Haumann
On Friday, 25. May 2012 21:42:50 Stephen Kelly wrote: > Christoph Cullmann wrote: > > Still, a fix for QtScript would be the nicest solution or a port to the > > "new" engine provided in Qt5, as I understood, there QtScript is anyway > > "deprecated" in favour of the V8 based new variant? > > Nope