Re: Review Request: Define tooltips for kdeui standard actions

2012-05-13 Thread David Jarvie
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104934/#review13793 --- Good idea! A couple of quick comments follow. kdeui/actions/k

Review Request: Define tooltips for kdeui standard actions

2012-05-13 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104934/ --- Review request for kdelibs. Description --- Attached patch tries to d

Re: kio and frameworks 5

2012-05-13 Thread Ben Martin
On Fri, 2012-05-11 at 21:33 +0100, Casper Clemence wrote: ... > > The discussions is this "what part should libferris take in the > refresh of KIO in KDE Frameworks 5?" > > > Ben Martin really should be involved in any discussion of a redesign > at the very least. He clearly has put a lot of wor

Re: kio and frameworks 5

2012-05-13 Thread Ben Martin
On Sun, 2012-05-13 at 12:58 +0200, David Faure wrote: > On Sunday 13 May 2012 11:32:46 Casper Clemence wrote: > > * it mounts lots more than an ordinary VFS - including XML documents (so > > the tree of the document can be browsed), databases, X (so that window > > position and size for example can

Re: Review Request: More kio_sftp login related fixes

2012-05-13 Thread Andreas Schneider
> On April 21, 2012, 9:05 a.m., Andreas Schneider wrote: > > Did you also test if keyboard-interactive still works correctly? > > Dawit Alemayehu wrote: > No, because I do not even know how to enable that functionality in my ssh > config and was lazy to search and find out. Just looking at

Re: kio and frameworks 5

2012-05-13 Thread Ben Martin
I thought I would hihack a reply to the windows support response to this message. For me that hasn't ever really been a priority so there isn't much support for it right now. The main issue would be the Linux file monitoring used by the file:// module. Beyond that there are some POSIX calls which

Re: kio and frameworks 5

2012-05-13 Thread Casper Clemence
On 13 May 2012 11:58, David Faure wrote: > > On Sunday 13 May 2012 11:32:46 Casper Clemence wrote: > > * it mounts lots more than an ordinary VFS - including XML documents (so > > the tree of the document can be browsed), databases, X (so that window > > position and size for example can be read a

Re: kio and frameworks 5

2012-05-13 Thread Casper Clemence
In short it is a virtual file system. However it takes the concept further in several respects (for a fuller answer read the "about" page): * it mounts lots more than an ordinary VFS - including XML documents (so the tree of the document can be browsed), databases, X (so that window position and s

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

2012-05-13 Thread Laszlo Papp
> On May 9, 2012, 6:30 p.m., Mark Gaiser wrote: > > Ehh optional perhaps? > > I've seen forms behave like this before and back then when i first saw it i > > tried to delete the text.. Which obviously didn't happen. The text just > > disappears as soon as i start typing. I kinda dislike that be

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-13 Thread Thomas Lübking
you probably wanted to point out that dawit ignored the perception of a typical user when introducing this checkbox, but it actually could be read as a disqualifying assumption about the condition of his mind. latter would indeed be ad hominem and not ad res, but ultimatily what we have here is ju

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-13 Thread Albert Astals Cid
El Diumenge, 13 de maig de 2012, a les 14:27:37, Sebastian Kügler va escriure: > On Sunday, May 13, 2012 12:20:00 Albert Astals Cid wrote: > > You probably don't have any bit of user mentallity left in your head, > > I think everybody is served better by discussions that do not engage in > persona

Re: Review Request: kjs: Fix Errorprototype inheritance

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104908/#review13781 --- Ship it! Ship It! - Maks Orlovich On May 10, 2012, 7:01 p.m

Re: Review Request: kjs: Introduce & use leftFirst parameter in relation check, according to Ecmascript 5.1r6.

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104906/#review13780 --- Any performance effect? - Maks Orlovich On May 10, 2012, 7:0

Re: Review Request: kjs: Update Error.prototype.toString to ECMA Edition 5.1r6 format

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104907/#review13779 --- Ship it! Ship It! - Maks Orlovich On May 10, 2012, 7:01 p.m

Re: Review Request: kjs: Implement standard String.trim, also non-standard trimLeft & trimRight

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104857/#review13778 --- Ship it! .. One of these days I'll manage to use reviewboard p

Re: Review Request: kjs: Implement standard String.trim, also non-standard trimLeft & trimRight

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104857/#review13777 --- kjs/string_object.cpp

Re: Review Request: kjs: Fix parseFloat not cutting-off leading unicode spaces

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104858/#review13776 --- I think this is the wrong place to fix this, actually; I think

Re: Review Request: kjs: Unify/de-duplicate Space checking

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104855/#review13775 --- Ship it! - Maks Orlovich On May 4, 2012, 5:40 p.m., Bernd Bu

Re: Review Request: kjs: Unify/de-duplicate Space checking

2012-05-13 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104855/#review13774 --- kjs/commonunicode.h

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-13 Thread Sebastian Kügler
On Sunday, May 13, 2012 12:20:00 Albert Astals Cid wrote: > You probably don't have any bit of user mentallity left in your head, I think everybody is served better by discussions that do not engage in personal attacks. Let us please try to keep it respectful and technical, and avoid ad-hominem

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-13 Thread Albert Astals Cid
> On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote: > > If i understand you correctly you are suggesting to create a bug (option > > that does nothing)? > > > > Doesn't make much sense. > > Dawit Alemayehu wrote: > Huh ? I do not follow. By "option that does nothing" you mean this cha

Re: kio and frameworks 5

2012-05-13 Thread David Faure
On Sunday 13 May 2012 11:32:46 Casper Clemence wrote: > * it mounts lots more than an ordinary VFS - including XML documents (so > the tree of the document can be browsed), databases, X (so that window > position and size for example can be read and modified as if they were data > in the filesystem

Re: kio and frameworks 5

2012-05-13 Thread Kevin Krammer
On Sunday, 2012-05-13, David Faure wrote: > On Friday 11 May 2012 21:33:35 Casper Clemence wrote: > > Libferris is an awesome piece of technology. It provides not just the > > traditional features of a VFS but a uniform method of access for > > applications and users to a large and expanding range

Re: kio and frameworks 5

2012-05-13 Thread Thiago Macieira
On domingo, 13 de maio de 2012 11.53.13, David Faure wrote: > On Friday 11 May 2012 21:33:35 Casper Clemence wrote: > > Libferris is an awesome piece of technology. It provides not just the > > traditional features of a VFS but a uniform method of access for > > applications and users to a large an

Re: kio and frameworks 5

2012-05-13 Thread David Faure
On Friday 11 May 2012 21:33:35 Casper Clemence wrote: > Libferris is an awesome piece of technology. It provides not just the > traditional features of a VFS but a uniform method of access for > applications and users to a large and expanding range of things What does it do exactly, and how? --

Re: Review Request: More kio_sftp login related fixes

2012-05-13 Thread Andreas Schneider
> On April 21, 2012, 9:05 a.m., Andreas Schneider wrote: > > Did you also test if keyboard-interactive still works correctly? > > Dawit Alemayehu wrote: > No, because I do not even know how to enable that functionality in my ssh > config and was lazy to search and find out. Just looking at