Re: Review Request: Plasma Components buttons: first focus, than emit clicked() signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104893/#review13632 --- This review has been submitted with commit fdb3ec834ee6912c82c

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review13631 --- This review has been submitted with commit 0707b07d3afb14870d5

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

> On May 9, 2012, 9:34 p.m., Andrea Diamantini wrote: > > Ship It! I like it. And code changes seem easy and safe. - Andrea --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review1

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

> On May 9, 2012, 8:53 p.m., Michael Jansen wrote: > > Hate to break the news to you after all that work. But the exact same thing > > you have achieved with this patch could be achieved by using a QAction for > > the missing Shortcut. Or a KAction for that matter as long as it is not > > part

Re: Review Request: Move the Preferred Web shorcut selection checkbox into its own column

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/#review13627 --- Ship it! Ship It! - Andrea Diamantini On May 9, 2012, 8:35

Re: Review Request: Plasma Components buttons: first focus, than emit clicked() signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104893/#review13626 --- Ship it! Good catch, please commit to KDE/4.8 and master or le

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13624 --- Hate to break the news to you after all that work. But the exac

Review Request: Move the Preferred Web shorcut selection checkbox into its own column

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104900/ --- Review request for KDE Runtime. Description --- The following patch m

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

> On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote: > > If i understand you correctly you are suggesting to create a bug (option > > that does nothing)? > > > > Doesn't make much sense. > > Dawit Alemayehu wrote: > Huh ? I do not follow. By "option that does nothing" you mean this cha

Re: Review Request: dataprotocol: make charset recoding work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104874/#review13620 --- This review has been submitted with commit 7fce249425be95ce3b4

Re: Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104895/#review13617 --- Ehh optional perhaps? I've seen forms behave like this before a

Re: Review Request: Plasma Components buttons: first focus, than emit clicked() signal

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104893/#review13616 --- I am unsure whether Plasma Components related patches are relev

Review Request: Plasma Components: TextField and TextArea: Show placeholders even if item has the focus

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104895/ --- Review request for KDE Runtime. Description --- Rationale: This allow

Re: Review Request: dataprotocol: simplify helper code

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104860/#review13611 --- This review has been submitted with commit 279694530bfd6df3b8c

Re: Review Request: Use the focus proxy, if present, as parent of KonqPopupMenu

> On May 9, 2012, 7:37 a.m., David Faure wrote: > > This makes no sense to me. Popping up a context menu has nothing to do with > > keyboard focus, and the actual cause for the bug hasn't been identified, > > apparently. So this is a "blind workaround", which I cannot approve. Well this is mos

KDE 4.9 feature plan

Hi all, It would be great if you could all take a few minutes to update the feature plan for 4.9 (preferably right now or you'll forget again!) http://techbase.kde.org/Schedules/KDE4/4.9_Feature_Plan as the Quality Team would need to identify new features, new applets, new apps,.. in order to

Re: Review Request: dataprotocol: make charset recoding work

> On May 9, 2012, 12:04 p.m., David Faure wrote: > > kio/kio/dataprotocol.cpp, line 71 > > > > > > Not sure the comment is still correct. "decoded"? It's not, anymore, > > right? It's just extracted? Or is it even t

Re: Re: Package Dependcies List on Techbase

Please excuse the Top-Post, my suggestion is VERY short: The terminology "Optional Dependency" sounds like a good term for these situations. (At least to me, a native 'en-us' person.) On 05/08/2012 06:18 AM, David Jarvie wrote: On Tue, May 8, 2012 1:07 pm, Allen Winter wrote: On Tuesday 08 Ma

Re: Review Request: dataprotocol: simplify helper code

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104860/#review13604 --- OK, except for const QChar &. kio/kio/dataprotocol.cpp

Re: Review Request: dataprotocol: make charset recoding work

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104874/#review13603 --- kio/kio/dataprotocol.cpp

Re: Review Request: Use the focus proxy, if present, as parent of KonqPopupMenu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104890/#review13602 --- This makes no sense to me. Popping up a context menu has nothin

Review Request: Use the focus proxy, if present, as parent of KonqPopupMenu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104890/ --- Review request for KDE Base Apps and David Faure. Description --- The