Re: Review Request: Add warning for searching the complete file system

2012-05-03 Thread Sebastian Kügler
On Thursday, May 03, 2012 19:35:00 Mark Gaiser wrote: > Let me first say that i have absolutely nothing to say about this. I do have > an opinion about this though. I would not like this. If i'm searching i > just want to search and certainly don't get a dialog just to confirm my > search. > > Oth

Re: Review Request: PreviewJob supports webpages

2012-05-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13375 --- This review has been submitted with commit bb5ef71483caaf1ce9c

Re: Review Request: PreviewJob supports webpages

2012-05-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13369 --- Ship it! Looks good to me. - Dawit Alemayehu On May 3, 2012

Re: Review Request: PreviewJob supports webpages

2012-05-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 3, 2012, 4:19 p.m.) Review request for KDE Runtime and Dawit

Re: Review Request: PreviewJob supports webpages

2012-05-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13356 --- kioslave/thumbnail/htmlcreator.cpp

Re: Review Request: PreviewJob supports webpages

2012-05-03 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 3, 2012, 3:20 p.m.) Review request for KDE Runtime and Dawit

Review Request: Add warning for searching the complete file system

2012-05-03 Thread Andre Heinecke
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104826/ --- Review request for KDE Base Apps. Description --- In my company it re

Re: Review Request: Fix Solid CMake check with Qt 5

2012-05-03 Thread Alexander Richardson
> On May 2, 2012, 11:43 a.m., Stephen Kelly wrote: > > Please do not submit this. It is out of date. You are probably using > > qt5.git which is way out of date. This is not needed anymore. Ok. How do I get a Qt 5 with which I can build kdelibs? Checkout master in every repo? - Alexander -

Re: [Nepomuk] The Nepomuk Situation

2012-05-03 Thread Sebastian Trüg
nepomuk-core depends on kdelibs. So kdelibs cannot depend on nepomuk-core. We would have to get rid of those dependencies in kdelibs. But that should not be too hard. On 05/03/2012 11:21 AM, Vishesh Handa wrote: > I just noticed that this discussion is no longer cced to kcd. > > On Thu, May 3, 20

Re: [Nepomuk] The Nepomuk Situation

2012-05-03 Thread Vishesh Handa
I just noticed that this discussion is no longer cced to kcd. On Thu, May 3, 2012 at 2:47 PM, Christian Mollekopf wrote: > > > On Thu, May 3, 2012, at 02:22 PM, Vishesh Handa wrote: > > > > On Thu, May 3, 2012 at 3:09 AM, Christian Mollekopf > wrote: > > > On Thursday 03 May 2012 00.32:37 Vish

Re: Review Request: make folderview icons translucent if composite is enabled

2012-05-03 Thread Hugo Pereira Da Costa
> On May 29, 2011, 1:05 p.m., Thomas Lübking wrote: > > Not sure wheher it's really worth it (though using ARGB over XShape might > > actually bring better performance) but I assume the style (oxygen) can deal > > this more efficiently (via polishment) and also globally (not only for the > > f

Re: Review Request: make folderview icons translucent if composite is enabled

2012-05-03 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101463/#review13308 --- For the record, I have implemented a 'modified' version of Thom