Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-02 Thread Dawit Alemayehu
> On May 2, 2012, 3:20 p.m., David Faure wrote: > > kio/kfile/kpropertiesdialog.cpp, line 332 > > > > > > Nice one, deleting the dialog immediately after show() ! > > > > See, this is exactly why I'm agains

Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-02 Thread Dawit Alemayehu
> On May 1, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kio/kfile/kurlrequesterdialog.cpp, line 133 > > > > > > replace tab to spaces. > > Dawit Alemayehu wrote: > For whomever wants to review these patch

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

2012-05-02 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated May 2, 2012, 8:23 p.m.) Review request for kdelibs. Changes ---

Re: The Nepomuk Situation

2012-05-02 Thread Ivan Cukic
> The first solution - > * Remove nepomuk from kdelibs and kde-runtime +1 This is what has been done with kactivities. Instead of having it in kdelibs and runtime, it is now all in one repository. The only difference here is that nepomuk is not in libs/experimental like libkactivities was. I t

The Nepomuk Situation

2012-05-02 Thread Vishesh Handa
Hey everyone! I've been meaning to write this forever, but I've gotten sidetracked with real life. Anyway, here it goes - As some of you might know, the Nepomuk source code is distributed over two different repositories. The client API is in kdelibs, and the rest is in kde-runtime. Developing bo

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-02 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/ --- (Updated May 2, 2012, 6:19 p.m.) Review request for kdelibs. Changes ---

Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104802/#review13274 --- kio/kfile/kpropertiesdialog.cpp

Re: Review Request: PreviewJob supports webpages

2012-05-02 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13273 --- kioslave/thumbnail/htmlcreator.cpp

Re: Review Request: Fix Solid CMake check with Qt 5

2012-05-02 Thread Stephen Kelly
> On May 2, 2012, 11:43 a.m., Stephen Kelly wrote: > > Please do not submit this. It is out of date. You are probably using > > qt5.git which is way out of date. This is not needed anymore. > > Alexander Richardson wrote: > Ok. How do I get a Qt 5 with which I can build kdelibs? Checkout ma

Re: Review Request: Fix Solid CMake check with Qt 5

2012-05-02 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104820/#review13267 --- Please do not submit this. It is out of date. You are probably

Re: Review Request: PreviewJob supports webpages

2012-05-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 2, 2012, 10:55 a.m.) Review request for KDE Runtime and Dawit

Re: Review request: AppMenu support for KDE

2012-05-02 Thread Cedric Bellegarde
Le vendredi 27 avril 2012 17:58:24 Alex Fiestas a écrit : > We should provide a way of accessing more easily to the data (thinking on a > model) and ideally would be awesome to have this before releasing. https://gitorious.org/kde-workspace-appmenu/krunner-kdedappmenu Here an old port of krunner

Re: Review Request: PreviewJob supports webpages

2012-05-02 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/#review13266 --- kioslave/thumbnail/htmlcreator.cpp

Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-02 Thread David Edmundson
> On May 1, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kio/kfile/kurlrequesterdialog.cpp, line 133 > > > > > > replace tab to spaces. > > Dawit Alemayehu wrote: > For whomever wants to review these patch

Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-02 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104802/#review13262 --- kio/kio/paste.cpp

Re: Review Request: Fix Solid CMake check with Qt 5

2012-05-02 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104820/ --- (Updated May 1, 2012, 11:28 p.m.) Review request for kdelibs. Descriptio

Re: Pairs going to KDE Edu

2012-05-02 Thread Aleix Pol
On Tue, May 1, 2012 at 9:29 AM, Aleix Pol wrote: > On Mon, Apr 30, 2012 at 10:07 AM, Yuri Chornoivan wrote: >> написане Mon, 30 Apr 2012 02:36:38 +0300, Aleix Pol : >> >> >>> On Mon, Apr 16, 2012 at 3:35 AM, Aleix Pol wrote: Hi, Last friday Pairs [1] was moved from playground/edu