Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-01 Thread Dawit Alemayehu
> On May 1, 2012, 6:15 p.m., Lamarque Vieira Souza wrote: > > kdeui/colors/kcolordialog.cpp, line 1484 > > > > > > You should use QWeakPointer instead of QPointer. There really is no point in doing that here excep

Re: Review Request: PreviewJob supports webpages

2012-05-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- (Updated May 2, 2012, 1:07 a.m.) Review request for KDE Runtime and Dawit

Review Request: PreviewJob supports webpages

2012-05-01 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104821/ --- Review request for KDE Runtime and Dawit Alemayehu. Description --- M

Review Request: Avoid using QDialog::exec in kpasswdserver to address long standing issue

2012-05-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104817/ --- Review request for KDE Runtime and David Faure. Description --- The a

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-01 Thread Michael Jansen
On Tuesday, May 01, 2012 06:05:01 PM Mark Gaiser wrote: This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/ On April 30th, 2012, 10:19 p.m., David Faure wrote: I am in favour of the idea, since I was hit by this limitation in the past, too. H

Re: Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-01 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104802/#review13236 --- kdeui/colors/kcolordialog.cpp

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

2012-05-01 Thread Mark Gaiser
> On April 30, 2012, 10:19 p.m., David Faure wrote: > > I am in favour of the idea, since I was hit by this limitation in the past, > > too. > > However I think the API changes should be more conservative, there's no > > need to deprecate so many of the existing methods, just because it is > >

Re: Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-05-01 Thread Dawit Alemayehu
> On April 26, 2012, 5:09 p.m., Albert Astals Cid wrote: > > If i understand you correctly you are suggesting to create a bug (option > > that does nothing)? > > > > Doesn't make much sense. Huh ? I do not follow. By "option that does nothing" you mean this change by itself does nothing that

Review Request: Mitigate potential crashes associated with the use of QDialog::exec in kdelibs

2012-05-01 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104802/ --- Review request for kdelibs. Description --- This patch attempts to mi

Re: Review Request: Minor krazy2 warning fixes

2012-05-01 Thread Dawit Alemayehu
> On May 1, 2012, 9:55 a.m., Konstantinos Smanis wrote: > > kioslave/http/kcookiejar/kcookiejar_include.h, line 6 > > > > > > Does it compile without the include? Yes that compiles fine. Even if certain includes are

Re: Pairs going to KDE Edu

2012-05-01 Thread Aleix Pol
On Mon, Apr 30, 2012 at 10:07 AM, Yuri Chornoivan wrote: > написане Mon, 30 Apr 2012 02:36:38 +0300, Aleix Pol : > > >> On Mon, Apr 16, 2012 at 3:35 AM, Aleix Pol wrote: >>> >>> Hi, >>> Last friday Pairs [1] was moved from playground/edu to kdereview >>> because we want it to be moved to kdeedu.

Re: Extra KDE Telepathy modules moving to Extragear

2012-05-01 Thread David Edmundson
On Sun, Apr 29, 2012 at 2:42 PM, Kevin Krammer wrote: > On Sunday, 2012-04-29, Martin Klapetek wrote: >> On Sat, Apr 28, 2012 at 22:44, Kevin Krammer wrote: >> > On Saturday, 2012-04-28, George Kiagiadakis wrote: >> > > No, the classes that wrap GObjects do not need a d-pointer. All the >> > > ca

Re: Pairs going to KDE Edu

2012-05-01 Thread Yuri Chornoivan
написане Mon, 30 Apr 2012 02:36:38 +0300, Aleix Pol : On Mon, Apr 16, 2012 at 3:35 AM, Aleix Pol wrote: Hi, Last friday Pairs [1] was moved from playground/edu to kdereview because we want it to be moved to kdeedu. We have been working on it for a while already and we would like it to move to

Re: Review Request: bilinear scaling for khtml/imload

2012-05-01 Thread Allan Sandfeld Jensen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104743/#review13194 --- Ship it! Ship It! - Allan Sandfeld Jensen On April 30, 2012