Re: Review Request: Minor krazy2 warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ --- (Updated April 30, 2012, 11:50 p.m.) Review request for kdelibs. Changes

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13186 --- This review has been submitted with commit 0057256b1a0a601346f

Re: Review Request: Change khtml settings to use KParts::HtmlSettingsInteface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104784/#review13185 --- This review has been submitted with commit 8766414fe43eb7c2df9

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13181 --- Ship it! Oh I see, it's a bug in reviewboard. The method name

Re: Review Request: Fix KShortcut to really allow the usage of multiple shortcuts

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104801/#review13178 --- I am in favour of the idea, since I was hit by this limitation

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

> On April 30, 2012, 8:41 p.m., David Faure wrote: > > Looks ok, but probably needs rebasing, the code in > > ProtoQueue::removeJob(SimpleJob *job) looks very different here. > > > > (I think checking for job being null is overzealous) Hmm... It applies just fine here on the 4.8 branch and I d

Re: Review Request: Minor krazy2 warning fixes

> On April 29, 2012, 7:56 p.m., Konstantinos Smanis wrote: > > kio/bookmarks/kbookmarkdombuilder.cc, line 41 > > > > > > You change the signature here (second argument: bool->QString) > > David Faure wrote: > Wo

Re: Review Request: bilinear scaling for khtml/imload

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104743/ --- (Updated April 30, 2012, 9:22 p.m.) Review request for kdelibs. Changes

Re: Review Request: Set the parent widget in KIO::SlaveInterface::messageBox

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104351/#review13169 --- Looks ok, but probably needs rebasing, the code in ProtoQueue:

Re: Review Request: Minor krazy2 warning fixes

> On April 29, 2012, 7:56 p.m., Konstantinos Smanis wrote: > > kio/bookmarks/kbookmarkdombuilder.cc, line 41 > > > > > > You change the signature here (second argument: bool->QString) Wow, well spotted. Dawit, don't

Re: Review Request: Add back and forward key binding in Dolphin

> On April 30, 2012, 4:54 p.m., Michael Jansen wrote: > > As albert said. The default shortcuts for the back acktion are "alt-" > > and "back key" as can be seen in "kcmshell4 standard_actions". > > > > Dolphin chose to overwrite the back key with backspace. A KAction > > unfortunately can onl

Review Request: kjs: Fix shift/reduce issues in grammar.y + cleanup

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104798/ --- Review request for kdelibs. Description --- kjs: Fix shift/reduce iss

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/ --- (Updated April 30, 2012, 7:11 p.m.) Review request for kdelibs. Changes

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

> On April 29, 2012, 6:26 p.m., Maks Orlovich wrote: > > kjs/object.cpp, line 433 > > > > > > more * inconsistency I don't get the problem here, could you please explain? > On April 29, 2012, 6:26 p.m., Maks Orlo

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/ --- (Updated April 30, 2012, 6:59 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add back and forward key binding in Dolphin

> On April 30, 2012, 4:54 p.m., Michael Jansen wrote: > > As albert said. The default shortcuts for the back acktion are "alt-" > > and "back key" as can be seen in "kcmshell4 standard_actions". > > > > Dolphin chose to overwrite the back key with backspace. A KAction > > unfortunately can onl

Re: Review Request: Add back and forward key binding in Dolphin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104796/#review13145 --- As albert said. The default shortcuts for the back acktion are

Re: Review Request: Add back and forward key binding in Dolphin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104796/#review13143 --- This probably makes Alt+left not work anymore as back shortcut

Re: Review Request: Add back and forward key binding in Dolphin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104796/ --- (Updated April 30, 2012, 3:41 p.m.) Review request for KDE Base Apps and P

Review Request: Add back and forward key binding in Dolphin

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104796/ --- Review request for KDE Base Apps and Peter Penz. Description --- Bug

Re: Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

> On April 30, 2012, 2:09 p.m., Lukáš Tinkl wrote: > > Has this been submitted? No, I did not get any feedback from maintainers. Not sure if it still makes sense, because Dolphin 4.9 gets a new places panel, not based on KFilePlacesView. The patch probably also does not fix the spin-up behavio

Re: Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103682/#review13134 --- Has this been submitted? - Lukáš Tinkl On Jan. 12, 2012, 4:4

Re: Pairs going to KDE Edu

On Mon, Apr 16, 2012 at 3:35 AM, Aleix Pol wrote: > Hi, > Last friday Pairs [1] was moved from playground/edu to kdereview > because we want it to be moved to kdeedu. We have been working on it > for a while already and we would like it to move to kde edu and to be > included in the next KDE relea

Re: Review Request: Minor krazy2 warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13105 --- kio/bookmarks/kbookmarkdombuilder.cc

Re: Review Request: KJS: Implement Object.GetOwnPropertyDescriptor & Object.DefineProperty

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104515/#review13085 --- Still need more big picture stuff... kjs/object.h