Re: Review Request: Minor krazy2 warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ --- (Updated April 29, 2012, 8:22 p.m.) Review request for kdelibs. Changes

Re: Review Request: Add cmake config for kdeclarative library.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104140/#review13110 --- This review has been submitted with commit d5b2e642a75ed4f0421

Re: Pairs going to KDE Edu

On Thursday 19 April 2012 23:32:51 Aleix Pol wrote: > On Thu, Apr 19, 2012 at 4:45 PM, Andrius da Costa Ribas > > wrote: > > Hello, > > > > Please find attached suggested patches to fix/improve Windows build. The URL handling code was broken indeed, but the suggested fix is still a bit buggy.

Re: Review Request: Minor krazy2 warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13102 --- Looks good, except for some #include changes. - David Faure

Re: Review Request: Minor krazy2 warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/#review13101 --- kio/bookmarks/konqbookmarkmenu.cc

Re: Review Request: Change khtml settings to use KParts::HtmlSettingsInteface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104784/#review13099 --- Ship it! Ship It! - David Faure On April 29, 2012, 6:40 p.m

Re: Moving kxmlrpcclient to kdelibs

On Sunday 29 April 2012 1:52:13 PM George Kiagiadakis wrote: > Hi, > > As I am about to commit [1] for 4.9, I'd like to conclude with what to > do about the kxmlrpcclient library. > > As discussed on that review request, it looks like a good idea to move > this library from kdepimlibs to kdelibs.

Review Request: Minor krazy2 warning fixes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104785/ --- Review request for kdelibs. Description --- The following patch fixes

Review Request: Change khtml settings to use KParts::HtmlSettingsInteface

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104784/ --- Review request for kdelibs. Description --- The attached patch change

Re: Review Request: kjs: Implement Object.seal & Object.isSealed

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104747/#review13096 --- Ship it! Again, ->toString, but nothing else. - Maks Orlovic

Re: Review Request: kjs: Implement Object.freeze & Object.isFrozen

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104748/#review13094 --- Ship it! Again, looks find except for ->toString in exception

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/#review13093 --- Ship it! Why not move the bit flags to property_map.h then?

Re: TechBase git policies, infrastructure documentation, please

Hi John, On Sunday 29 April 2012, John Layt wrote: ... > For the actual repo layout and building KDE step-by-step that can be found > under http://techbase.kde.org/Getting_Started especially under > http://techbase.kde.org/Getting_Started/Sources, and for individual modules > in their pages under

Re: Review Request: kjs: Implement Object.defineProperties

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104629/#review13090 --- Ship it! Looks OK modulo generic remarks on use of ->toString

Re: Review Request: kjs: Implement Object.create

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104630/#review13088 --- Ship it! Looks OK modulo generic remarks on use of ->toString

Moving kxmlrpcclient to kdelibs

Hi, As I am about to commit [1] for 4.9, I'd like to conclude with what to do about the kxmlrpcclient library. As discussed on that review request, it looks like a good idea to move this library from kdepimlibs to kdelibs. Other options are to make kde-runtime depend on kdepimlibs or bundle kxmlr

Re: TechBase git policies, infrastructure documentation, please

Alexander Neundorf wrote: > On Sunday 29 April 2012, Stephen Kelly wrote: >> Alexander Neundorf wrote: >> > git is a powerful tool, and you can use it in many different ways. It >> > needs to be easy to find out how git is intended to be used in KDE. I >> > don't know where this is documented. I e

Re: TechBase git policies, infrastructure documentation, please

On Sunday 29 Apr 2012 13:11:19 Alexander Neundorf wrote: > Hi, > > I wanted to look how our current branching, committing etc. git polices are. > So I went to techbase.kde.org -> Development -> git. > > Nothing at all about git policies: > http://techbase.kde.org/Development/Git#KDE_Git_Policies

Re: TechBase git policies, infrastructure documentation, please

On Sunday 29 April 2012, Stephen Kelly wrote: > Alexander Neundorf wrote: > > git is a powerful tool, and you can use it in many different ways. It > > needs to be easy to find out how git is intended to be used in KDE. I > > don't know where this is documented. I expect this on techbase. > > It i

Re: TechBase git policies, infrastructure documentation, please

Alexander Neundorf wrote: > git is a powerful tool, and you can use it in many different ways. It > needs to be easy to find out how git is intended to be used in KDE. I > don't know where this is documented. I expect this on techbase. It is indeed not on techbase as far as I can see too. Do you

Re: Extra KDE Telepathy modules moving to Extragear

On Sunday, 2012-04-29, Martin Klapetek wrote: > On Sat, Apr 28, 2012 at 22:44, Kevin Krammer wrote: > > On Saturday, 2012-04-28, George Kiagiadakis wrote: > > > No, the classes that wrap GObjects do not need a d-pointer. All the > > > calls are forwarded to the underlying GObject and if for any re

Re: TechBase git policies, infrastructure documentation, please

On Sunday 29 April 2012, Alexander Neundorf wrote: > On Sunday 29 April 2012, Martin Gräßlin wrote: > > On Sunday 29 April 2012 13:11:19 Alexander Neundorf wrote: > > > Can somebody please take care of the sorry state of our git > > > documentation ? There were so many people supporting it, can ple

Re: Extra KDE Telepathy modules moving to Extragear

On Sun, Apr 29, 2012 at 2:34 PM, Sune Vuorela wrote: > On 2012-04-28, George Kiagiadakis wrote: >> No, the classes that wrap GObjects do not need a d-pointer. All the >> calls are forwarded to the underlying GObject and if for any reason we >> ever need to save extra data on the wrapper class (wh

Re: Extra KDE Telepathy modules moving to Extragear

On 2012-04-28, George Kiagiadakis wrote: > No, the classes that wrap GObjects do not need a d-pointer. All the > calls are forwarded to the underlying GObject and if for any reason we > ever need to save extra data on the wrapper class (which is highly > unlikely), we should use the GObject qdata

Re: TechBase git policies, infrastructure documentation, please

On Sunday 29 April 2012, Martin Gräßlin wrote: > On Sunday 29 April 2012 13:11:19 Alexander Neundorf wrote: > > Can somebody please take care of the sorry state of our git documentation > > ? There were so many people supporting it, can please somebody document > > it ? On techbase.kde.org, not in

Re: TechBase git policies, infrastructure documentation, please

On Sunday 29 April 2012 13:11:19 Alexander Neundorf wrote: > Can somebody please take care of the sorry state of our git documentation ? > There were so many people supporting it, can please somebody document it ? > On techbase.kde.org, not in some blog or wherever. For the record: http://community

TechBase git policies, infrastructure documentation, please

Hi, I wanted to look how our current branching, committing etc. git polices are. So I went to techbase.kde.org -> Development -> git. Nothing at all about git policies: http://techbase.kde.org/Development/Git#KDE_Git_Policies Ah, maybe git stuff is actually here: http://techbase.kde.org/Policies