Re: Review Request: Do not patch strings that can be combined.

2012-04-24 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104712/#review12889 --- This review has been submitted with commit a35a6c8bc56028f704d

Re: Review Request: Do not patch strings that can be combined.

2012-04-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104712/#review12884 --- Ship it! Ship It! - Dawit Alemayehu On April 24, 2012, 5:01

Review Request: Do not patch strings that can be combined.

2012-04-24 Thread Frederik Schwarzer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104712/ --- Review request for KDE Base Apps. Description --- The way it is now,

Re: Re: Re: KIO / KWebView and PrivateBrowsing (Cookies)

2012-04-24 Thread Alex Fiestas
After reading the patch and understanding a little bit more how this work I reached the following conclusion (potentially wrong as before :p). storageDisabled should work as it does right now (without the patch), it does disable any storage and allow reading, which imho it is exactly what you e

Re: Re: KIO / KWebView and PrivateBrowsing (Cookies)

2012-04-24 Thread Alex Fiestas
On Monday, April 23, 2012 07:38:16 PM Dawit A wrote: > None of this is necessary. What should happen in private browsing mode is > the "cookies" metadata should be set to "manual" to disable cookie handling > kio_http. The KIO::Integration::AccessManager can be modified to send its > own cookie hea