Re: Review Request: "data:" protocol: don't treat fragments as part of the data

2012-04-17 Thread Rolf Eike Beer
> On April 17, 2012, 7:47 p.m., David Faure wrote: > > kio/kio/dataprotocol.cpp, line 181 > > > > > > This looks wrong. If you call url.path(), you have a decoded string, so > > no need to call fromPercentEncoding

Re: Review Request: Ensure authentication data is cached properly in Dolphin

2012-04-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104614/#review12614 --- This review has been submitted with commit ff37139bcfa02973499

Re: Review Request: "data:" protocol: don't treat fragments as part of the data

2012-04-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104624/#review12612 --- kio/kio/dataprotocol.cpp

Re: Setting up a Quality Team within KDE

2012-04-17 Thread Alexander Neundorf
On Monday 16 April 2012, Andras Mantia wrote: > On Monday, April 16, 2012 08:59:13 AM Volker Krause wrote: > > I don't think UI is necessarily easier to change than internal API, > > the key difference is that you'll get a compile error for the unit > > test, while you wont notice a broken Squish

Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon

2012-04-17 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104625/#review12590 --- This review has been submitted with commit 8d8e6065b584ad32be2

Re: Pairs going to KDE Edu

2012-04-17 Thread Albert Astals Cid
El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure: > Hi, > Last friday Pairs [1] was moved from playground/edu to kdereview > because we want it to be moved to kdeedu. We have been working on it > for a while already and we would like it to move to kde edu and to be > included i

Re: Review Request: Change Online help icon KHelpcenter

2012-04-17 Thread Albert Astals Cid
> On April 17, 2012, 1:45 p.m., Sebastian Kügler wrote: > > This change is wrong, as the menu entry has nothing to do with the semantic > > meaning of the icon, and the icon is not named according to the icon spec. > > > > So the correct icon is already set here, if its look doesn't match, then

Re: Review Request: Change Online help icon KHelpcenter

2012-04-17 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104621/#review12573 --- This change is wrong, as the menu entry has nothing to do with

Re: Review Request: Ensure authentication data is cached properly in Dolphin

2012-04-17 Thread Dawit Alemayehu
> On April 16, 2012, 2:03 p.m., Peter Penz wrote: > > Thanks for the patch, I've not been aware that this caching-issue can be > > solved like this :-) I guess this patch has not been applied to the latest > > master: DolphinView does not have a dir-lister anymore (it has been moved > > to KFi

Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon

2012-04-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104625/#review12563 --- Ship it! Ship It! - Dawit Alemayehu On April 16, 2012, 8:30

Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon

2012-04-17 Thread Dawit Alemayehu
> On April 16, 2012, 11:34 p.m., Dawit Alemayehu wrote: > > But your change now makes it possible to have a header without any spaces > > after the colon as well. Despite that only affecting headers from the > > cache, which what your patch does, I do not see the point here. Do you want > > to

Re: Setting up a Quality Team within KDE

2012-04-17 Thread Andreas Pakulat
On 16.04.12 23:52:00, Andras Mantia wrote: > On Monday, April 16, 2012 08:59:13 AM Volker Krause wrote: > > I don't think UI is necessarily easier to change than internal API, > > the key difference is that you'll get a compile error for the unit > > test, while you wont notice a broken Squish tes

Re: Setting up a Quality Team within KDE

2012-04-17 Thread Andras Mantia
On Monday, April 16, 2012 08:59:13 AM Volker Krause wrote: > I don't think UI is necessarily easier to change than internal API, > the key difference is that you'll get a compile error for the unit > test, while you wont notice a broken Squish test immediately. I was thinking about such innocent

Review Request: More kio_sftp login related fixes

2012-04-17 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104642/ --- Review request for KDE Runtime and Andreas Schneider. Description ---