Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon

2012-04-16 Thread Rolf Eike Beer
> On April 16, 2012, 11:34 p.m., Dawit Alemayehu wrote: > > But your change now makes it possible to have a header without any spaces > > after the colon as well. Despite that only affecting headers from the > > cache, which what your patch does, I do not see the point here. Do you want > > to

Re: Re: Re: Shortcuts (WAS: [Development] api changes)

2012-04-16 Thread Martin Gräßlin
On Monday 16 April 2012 15:00:39 Rick Stockton wrote: > I know that such a request is only "an optional suggestion" to the WM. > Now, looking ahead: Do we want KWin (and maybe PLasma, as well) to > continue "skip layers", going directly to xcb or wayland (or ??) in the > same way we currently do a

Re: Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon

2012-04-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104625/#review12545 --- But your change now makes it possible to have a header without

Review Request: Added option for disabling the offer to save website passwords in Konqueror

2012-04-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104631/ --- Review request for KDE Base Apps and David Faure. Description --- A p

Review Request: kjs: Implement Object.create

2012-04-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104630/ --- Review request for kdelibs. Description --- This needs https://git.re

Review Request: kjs: Implement Object.defineProperties

2012-04-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104629/ --- Review request for kdelibs. Description --- This requieres https://gi

Re: Re: Shortcuts (WAS: [Development] api changes)

2012-04-16 Thread Thomas Lübking
Am 17.04.2012, 00:00 Uhr, schrieb Rick Stockton : Now, looking ahead: Do we want KWin (and maybe PLasma, as well) to continue "skip layers", going directly to xcb or wayland (or ??) in the same way we currently do a lot of X11 queries and commands directly? Not much idea about strategic p

Re: Review Request: Do not use the port number from /etc/services in sftpProtocol::setHost

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104617/#review12543 --- This review has been submitted with commit 12645a4a933a5b06016

Re: Review Request: Do not use the port number from /etc/services in sftpProtocol::setHost

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104617/#review12542 --- This review has been submitted with commit bc244993b470ec3d5fc

Re: Review Request: KJS: Correctly get begin, deleteCount for Splice

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104104/#review12540 --- This review has been submitted with commit 5084dfd772ac39dbbb9

Re: Review Request: KJS: No longer treat invalid hex as string

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review12541 --- This review has been submitted with commit d4d5843d14deed8c8bd

Re: Re: Shortcuts (WAS: [Development] api changes)

2012-04-16 Thread Rick Stockton
On 04/16/2012 01:53 PM, Thomas Lübking wrote: Not much idea about the context, but Context was handheld- where Qt wants to be capable. Managing windows is a task only for the workspace applications. Putting those classes in a generic library is a mistake. Am 16.04.2012, 21:25 Uhr, schrieb

Re: Review Request: Limit KDateComboBox date keywords to the date range set for the widget

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104198/#review12536 --- This review has been submitted with commit 84892bf020e44c21def

Re: Review Request: Pass decorationSize to QStyleOptionView in KWidgetItemDelegatePrivate

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104322/#review12537 --- This review has been submitted with commit 903bb057742f21c5908

Re: Review Request: Ensure authentication data is cached properly in Dolphin

2012-04-16 Thread Peter Penz
> On April 16, 2012, 2:03 p.m., Peter Penz wrote: > > Thanks for the patch, I've not been aware that this caching-issue can be > > solved like this :-) I guess this patch has not been applied to the latest > > master: DolphinView does not have a dir-lister anymore (it has been moved > > to KFi

Re: Shortcuts (WAS: [Development] api changes)

2012-04-16 Thread Thomas Lübking
Not much idea about the context, but Managing windows is a task only for the workspace applications. Putting those classes in a generic library is a mistake. Am 16.04.2012, 21:25 Uhr, schrieb Rick Stockton : I disagree. Things such as "Window Position", Size, and the need to Move a Window

Re: Review Request: Fix KWidgetItemDelegate not updating on FocusIn and FocusOut

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104149/#review12534 --- This review has been submitted with commit 3e23f2046b2854ded3a

Review Request: HTTP ioslave: do not require incoming headers to have spaces after colon

2012-04-16 Thread Rolf Eike Beer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104625/ --- Review request for kdelibs. Description --- The RfCs suggest to use a

Re: Pairs going to KDE Edu

2012-04-16 Thread Aleix Pol
On Mon, Apr 16, 2012 at 9:32 PM, Burkhard Lück wrote: > Am Montag, 16. April 2012, 03:35:51 schrieb Aleix Pol: >> Hi, >> Last friday Pairs [1] was moved from playground/edu to kdereview >> because we want it to be moved to kdeedu. We have been working on it >> for a while already and we would like

Re: Pairs going to KDE Edu

2012-04-16 Thread Aleix Pol
On Mon, Apr 16, 2012 at 7:53 PM, Albert Astals Cid wrote: > El Dilluns, 16 d'abril de 2012, a les 19:44:33, Marco Calignano va escriure: >> On 04/16/2012 07:05 PM, Albert Astals Cid wrote: >> > El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure: >> >> Hi, >> >> Last friday Pairs

Re: Pairs going to KDE Edu

2012-04-16 Thread Aleix Pol
On Mon, Apr 16, 2012 at 4:41 PM, Raphael Kubo da Costa wrote: > Aleix Pol writes: > >> Hi, >> Last friday Pairs [1] was moved from playground/edu to kdereview >> because we want it to be moved to kdeedu. We have been working on it >> for a while already and we would like it to move to kde edu and

Review Request: Change Online help icon KHelpcenter

2012-04-16 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104621/ --- Review request for KDE Runtime and Cornelius Schumacher. Summary (updated)

Re: Review Request: Do not use the port number from /etc/services in sftpProtocol::setHost

2012-04-16 Thread Andreas Schneider
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104617/#review12512 --- Ship it! Thanks for all the work you're doing here. - Andreas

Re: Shortcuts (WAS: [Development] api changes)

2012-04-16 Thread Rick Stockton
The main text of my reply is at the bottom ... On 04/16/2012 05:15 AM, Michael Jansen wrote: On Sunday, April 15, 2012 08:40:38 PM Thiago Macieira wrote: On segunda-feira, 16 de abril de 2012 01.33.31, Stephen Kelly wrote: The only applications that should do that are the workspace fixture one

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

2012-04-16 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/ --- (Updated April 16, 2012, 5:51 p.m.) Review request for kdelibs. Descript

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

2012-04-16 Thread Bernd Buschinski
> On April 15, 2012, 2:55 p.m., Maks Orlovich wrote: > > kjs/function.cpp, line 302 > > > > > > re: if length changed --- I think this should be using ->size from > > indexToNameMap rather than the length property.

Re: Pairs going to KDE Edu

2012-04-16 Thread Albert Astals Cid
El Dilluns, 16 d'abril de 2012, a les 19:02:25, Albert Astals Cid va escriure: > El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure: > > Hi, > > Last friday Pairs [1] was moved from playground/edu to kdereview > > because we want it to be moved to kdeedu. We have been working on

Re: Pairs going to KDE Edu

2012-04-16 Thread Albert Astals Cid
El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure: > Hi, > Last friday Pairs [1] was moved from playground/edu to kdereview > because we want it to be moved to kdeedu. We have been working on it > for a while already and we would like it to move to kde edu and to be > included i

Re: Pairs going to KDE Edu

2012-04-16 Thread Albert Astals Cid
El Dilluns, 16 d'abril de 2012, a les 03:35:51, Aleix Pol va escriure: > Hi, > Last friday Pairs [1] was moved from playground/edu to kdereview > because we want it to be moved to kdeedu. We have been working on it > for a while already and we would like it to move to kde edu and to be > included i

Re: Pairs going to KDE Edu

2012-04-16 Thread Raphael Kubo da Costa
Aleix Pol writes: > Hi, > Last friday Pairs [1] was moved from playground/edu to kdereview > because we want it to be moved to kdeedu. We have been working on it > for a while already and we would like it to move to kde edu and to be > included in the next KDE release. > > If someone is intereste

Re: Review Request: Ensure authentication data is cached properly in Dolphin

2012-04-16 Thread Dawit Alemayehu
> On April 16, 2012, 2:03 p.m., Peter Penz wrote: > > Thanks for the patch, I've not been aware that this caching-issue can be > > solved like this :-) I guess this patch has not been applied to the latest > > master: DolphinView does not have a dir-lister anymore (it has been moved > > to KFi

Review Request: Do not use the port number from /etc/services in sftpProtocol::setHost

2012-04-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104617/ --- Review request for KDE Runtime and Andreas Schneider. Description ---

Re: Review Request: Ensure authentication data is cached properly in Dolphin

2012-04-16 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104614/#review12509 --- Thanks for the patch, I've not been aware that this caching-iss

Review Request: Ensure authentication data is cached properly in Dolphin

2012-04-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104614/ --- Review request for KDE Base Apps and Peter Penz. Description --- The

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-16 Thread Lamarque Vieira Souza
> On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote: > > This is actually a bug that needs to be addressed differently. Your > > solution is simply a hack. Normally Nepomuk should not return those results > > at all. The question is though: why does it? Only if we figure that out we > > can

Pairs going to KDE Edu

2012-04-16 Thread Aleix Pol
Hi, Last friday Pairs [1] was moved from playground/edu to kdereview because we want it to be moved to kdeedu. We have been working on it for a while already and we would like it to move to kde edu and to be included in the next KDE release. If someone is interested, please take a look into it and

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12477 --- This review has been submitted with commit 7e2ef3c7f0a6584a040

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-04-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12476 --- This review has been submitted with commit f0983fa9a3a1f4466b7

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-16 Thread Sebastian Trueg
> On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote: > > This is actually a bug that needs to be addressed differently. Your > > solution is simply a hack. Normally Nepomuk should not return those results > > at all. The question is though: why does it? Only if we figure that out we > > can

Re: Setting up a Quality Team within KDE

2012-04-16 Thread Volker Krause
On Monday 16 April 2012 08:02:51 Andras Mantia wrote: > On Thursday, April 12, 2012 10:49:10 PM Alexander Neundorf wrote: > > Yes, how good squish works for you depends on at least two things: > We also use Squish, and it found bugs and regressions in our code. > Still, there is a big problem with