Re: Setting up a Quality Team within KDE

2012-04-15 Thread Andras Mantia
On Thursday, April 12, 2012 10:49:10 PM Alexander Neundorf wrote: > Yes, how good squish works for you depends on at least two things: We also use Squish, and it found bugs and regressions in our code. Still, there is a big problem with it: the test needs to be maintained constantly. If they are

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-15 Thread Lamarque Vieira Souza
> On April 15, 2012, 5:21 p.m., Sebastian Trueg wrote: > > This is actually a bug that needs to be addressed differently. Your > > solution is simply a hack. Normally Nepomuk should not return those results > > at all. The question is though: why does it? Only if we figure that out we > > can

Re: Review Request: Make nepomuk runner remove undesired matches

2012-04-15 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104526/#review12482 --- This is actually a bug that needs to be addressed differently.

Re: Review Request: KJS: Correctly get begin, deleteCount for Splice

2012-04-15 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104104/#review12474 --- Ship it! Ship It! - Maks Orlovich On March 21, 2012, 11:55

Re: Review Request: KJS: No longer treat invalid hex as string

2012-04-15 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/#review12473 --- Ship it! Ship It! - Maks Orlovich On March 21, 2012, 11:52

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

2012-04-15 Thread Maks Orlovich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104511/#review12471 --- khtml/ecma/kjs_css.h

Re: Review Request: KJS: Implement Object.prototypeOf, Object.keys, Object.getOwnPropertyNames

2012-04-15 Thread Maks Orlovich
> On April 10, 2012, 2:38 a.m., Maks Orlovich wrote: > > kjs/function.cpp, line 308 > > > > > > Why convert to ident when isMapped will convert back to number again? > > Just add aversion that takes a number; simi