Re: Review Request: kdepasswd KCM: fixed freeze when changing user name

2012-03-31 Thread Sergey Borovkov
> On March 31, 2012, 8:08 p.m., Raphael Kubo da Costa wrote: > > Could you detail a bit more what was wrong with the way the output is/was > > being parsed? > > Sergey Borovkov wrote: > I'll post it in few hours, sorry for not posting it when I made review > request So the bug was that "C

Re: Review Request: kdepasswd KCM: fixed freeze when changing user name

2012-03-31 Thread Sergey Borovkov
> On March 31, 2012, 8:08 p.m., Raphael Kubo da Costa wrote: > > Could you detail a bit more what was wrong with the way the output is/was > > being parsed? I'll post it in few hours, sorry for not posting it when I made review request - Sergey --

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
> On March 31, 2012, 5:04 p.m., Lamarque Vieira Souza wrote: > > service/plugins/globalshortcuts/globalshortcuts.cpp, line 66 > > > > > > please stick to the code style, use "QString & activity" here. It will not co

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated March 31, 2012, 7:48 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12071 --- service/plugins/globalshortcuts/activitymanager-plugin-globals

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated March 31, 2012, 6:15 p.m.) Review request for KDE Base Apps, KDE

Re: Hunting a memory leak in KMail

2012-03-31 Thread Rolf Eike Beer
Am Samstag 31 März 2012, 23:48:57 schrieb Alex Fiestas: > For some time I have been experiencing a memory leak that makes KMail go up > to 1,5Gb of ram when using it for a long period of time, Volker saw it with > his own eyes and we even tried to valgrind it. > > I have been using KMail while keep

Hunting a memory leak in KMail

2012-03-31 Thread Alex Fiestas
For some time I have been experiencing a memory leak that makes KMail go up to 1,5Gb of ram when using it for a long period of time, Volker saw it with his own eyes and we even tried to valgrind it. I have been using KMail while keeping an eye in ksysguard and I think I know where the leak is (

Re: Review Request: kdepasswd KCM: fixed freeze when changing user name

2012-03-31 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104439/#review12073 --- Could you detail a bit more what was wrong with the way the out

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Stephen Kelly
Now I'm confused. >> Stephen Kelly wrote: >> It was rebased onto some relatively recent commit, but not the tip of >> the branch. You disagreed with what I said: > - Given that the branch was rebased on top of the last frameworks' commit > (as you can see from the log), ... actually

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Dario Freddi
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote: > > April is upon us. If no objections arise in the time being, these changes > > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to > > tier2/ for prime time. > > Stephen Kelly wrote: > Thanks for making this happ

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12067 --- service/plugins/globalshortcuts/globalshortcuts.h

Re: Review Request: Remember current desktop when changing activity

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review12069 --- This review has been submitted with commit 43b05d53caa0f382dcf

Re: Review Request: Remember current desktop when changing activity

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review12068 --- This review has been submitted with commit 6397ef5f8977af0d867

Re: simon: Review for move to extragear/accessibility

2012-03-31 Thread Peter Grasch
Simon has been moved to extragear/accessibility. Thanks to all involved. Best regards, Peter

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/#review12066 --- You're awesome mate :) service/plugins/globalshortcuts/activi

Re: Review Request: GlobalShortcuts Plugin for ActivityManager (kamd)

2012-03-31 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104428/ --- (Updated March 31, 2012, 4:19 p.m.) Review request for KDE Base Apps, KDE

Re: Review Request: include KolorManager in kdegraphics

2012-03-31 Thread Boudewijn Rempt
On Saturday 31 March 2012 Mar, Kai-Uwe Behrmann wrote: > Given the recent discussions in this thread, there is not something > fundamentally technical to change inside KolorManager. Many have expressed > the opinion to move it not into kdegraphics ATM and use kdeextragear > instead. > > As mos

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Stephen Kelly
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote: > > April is upon us. If no objections arise in the time being, these changes > > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to > > tier2/ for prime time. > > Stephen Kelly wrote: > Thanks for making this happ

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Dario Freddi
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote: > > April is upon us. If no objections arise in the time being, these changes > > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to > > tier2/ for prime time. > > Stephen Kelly wrote: > Thanks for making this happ

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Stephen Kelly
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote: > > April is upon us. If no objections arise in the time being, these changes > > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to > > tier2/ for prime time. > > Stephen Kelly wrote: > Thanks for making this happ

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Dario Freddi
> On March 30, 2012, 1:14 p.m., Dario Freddi wrote: > > April is upon us. If no objections arise in the time being, these changes > > will be merged on Sunday, after which I'll ask Kevin to move KAuth back to > > tier2/ for prime time. > > Stephen Kelly wrote: > Thanks for making this happ

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-31 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review12059 --- This review has been submitted with commit 1f6e4685b66090c3e99

Re: Review Request: include KolorManager in kdegraphics

2012-03-31 Thread Kai-Uwe Behrmann
Am 14.03.12, 11:26 +0100 schrieb Kai-Uwe Behrmann: Request ID: https://bugs.kde.org/show_bug.cgi?id=295987 About: KolorManager is a front end to the Oyranos Colour Management System (CMS). Why: Colour Management is a important part of modern desktops. It helps designers to improve colour usabi