Re: Re: Re: [GSoC] KWin colour management

On Thursday 22 March 2012 07:02:27 Kai-Uwe Behrmann wrote: > Am 21.03.12, 20:34 +0100 schrieb Martin Gräßlin: > > I think you do not know how KWin's rendering works. In a simplistic way: a > > window is rendered to the screen through a shader. At runtime KWin decides > > which shader to be used. As

Re: Re: [GSoC] KWin colour management

Am 21.03.12, 20:34 +0100 schrieb Martin Gräßlin: I think you do not know how KWin's rendering works. In a simplistic way: a window is rendered to the screen through a shader. At runtime KWin decides which shader to be used. As by that there is always only one active shader, so to have color corre

Re: Review Request: Make KAuth ready for frameworks + API Changes

> On March 21, 2012, 8:54 p.m., Alexander Neundorf wrote: > > I did not yet have time to look through the git branch... > > > > So, kauth, we have a bunch of cmake macros related to this in > > kdelibs/cmake/KDE4Macros.cmake, right ? > > What about them ? > > Stephen Kelly wrote: > They ar

Re: Review Request: KJS: Extend strictEqual check for numbers by NaN and signbit check

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104358/ --- (Updated March 22, 2012, 12:41 a.m.) Review request for kdelibs. Changes

Re: Review Request: KJS/Grammar: Introduce new non-terminal IdentifierName, to handle keywords as PropertyName, in Memberexps and CallExpr

> On March 20, 2012, 9:30 p.m., Maks Orlovich wrote: > > Can I presume this change doesn't changer # of conflicts? > > I don't understand what conflicts you mean. If you mean failing tests in ecmascript262, it does change the number, it recudes the fails by ~50 - Bernd -

Review Request: KJS: Extend strictEqual check for numbers by NaN and signbit check

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104358/ --- Review request for kdelibs. Description --- In c++ NAN == NAN return

Re: Review Request: KJS: Correctly get begin, deleteCount for Splice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104104/ --- (Updated March 21, 2012, 11:55 p.m.) Review request for kdelibs. Changes

Re: Review Request: KJS: No longer treat invalid hex as string

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104076/ --- (Updated March 21, 2012, 11:52 p.m.) Review request for kdelibs. Changes

Re: Review Request: KJS: No longer treat invalid hex as string

> On March 20, 2012, 9:18 p.m., Maks Orlovich wrote: > > kjs/lexer.cpp, line 320 > > > > > > Any reason you're still permitting this recovery (testcase: "\x")? > > > > Because I feared it would break even more

Re: Review Request: Make KAuth ready for frameworks + API Changes

> On March 21, 2012, 8:54 p.m., Alexander Neundorf wrote: > > I did not yet have time to look through the git branch... > > > > So, kauth, we have a bunch of cmake macros related to this in > > kdelibs/cmake/KDE4Macros.cmake, right ? > > What about them ? They are already in ${CMAKE_SOURCE_DIR

Re: [GSoC] KWin colour management

On Wednesday 21 March 2012 20.34.00 Martin Gräßlin wrote: > > Personally I would not make inclusion of code a pre condition for the > > success of such a project. Upstream inclusion of code is a high goal for > > contributors anywhere. Not many GSoC projects reach that immediately. > > If you don'

Re: Review Request: Make KAuth ready for frameworks + API Changes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11717 --- I did not yet have time to look through the git branch... So,

Re: Re: [GSoC] KWin colour management

On Wednesday 21 March 2012 19:14:51 Kai-Uwe Behrmann wrote: > Am 21.03.12, 18:20 +0100 schrieb Martin Gräßlin: > > On Wednesday 21 March 2012 08:23:39 Kai-Uwe Behrmann wrote: > >>> There is more into it: first of all KWin currently does not distinguish > >>> between screens during rendering. To pro

Re: Review Request: Remember current desktop when changing activity

> On March 21, 2012, 6:29 p.m., Ivan Čukić wrote: > > Ship It! please forgive my ignorance, but should i close it as submitted or wait? :-) - makis --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.k

Re: Review Request: Remember current desktop when changing activity

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/#review11705 --- Ship it! Ship It! - Ivan Čukić On March 18, 2012, 9:22 a.m.

Re: [GSoC] KWin colour management

Am 21.03.12, 18:20 +0100 schrieb Martin Gräßlin: On Wednesday 21 March 2012 08:23:39 Kai-Uwe Behrmann wrote: There is more into it: first of all KWin currently does not distinguish between screens during rendering. To properly have screen aware color correction the complete compositor has to be

Re: Status of KSecretService

Kubuntu also has a bug asking for KSecretsService added to the kwallet KCM. https://bugs.launchpad.net/kubuntu-ppa/+bug/934448 But I am yet to find how to do that. Jonathan

Re: Re: [GSoC] KWin colour management

On Wednesday 21 March 2012 08:23:39 Kai-Uwe Behrmann wrote: > > There is more into it: first of all KWin currently does not distinguish > > between screens during rendering. To properly have screen aware color > > correction the complete compositor has to be made screen aware. The > > repaint loop

Re: Status of KSecretService

On Wed, Mar 21, 2012 at 01:58:53PM +0100, Alex Fiestas wrote: > What's the status of KSecretService ? is it stuck because of Frameworks? It is a released part of KDE SC, but nobody seems to have packaged or tested it. I think it should be removed from KDE SC until it is better tested. > If I rem

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

On Wednesday 21 March 2012 09:06:05 Lamarque V. Souza wrote: > Em Wednesday 21 March 2012, David Faure escreveu: > > On Tuesday 20 March 2012 22:31:57 Lamarque V. Souza wrote: > > > WeatherEngine::~WeatherEngine() calls > > > WeatherEngine::unloadIons(), which tries to use the invalid > > > Plasma:

Status of KSecretService

What's the status of KSecretService ? is it stuck because of Frameworks? Do we have any plan to put it in production for 4.9 ? How the migration will be handled? If I remember correctly the current Wallet API will still work right? should we port applications to new api anyway? Final question,

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

Em Wednesday 21 March 2012, Aaron J. Seigo escreveu: > On Tuesday, March 20, 2012 22:31:57 Lamarque V. Souza wrote: > > There is a crash in WeatherEngine (kde-workspace) triggered by the fact > > > > that Plasma::DataEngineManager::self() (kdelib) is invalid when > > plasma-{desktop,device} ar

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

Em Wednesday 21 March 2012, David Faure escreveu: > On Tuesday 20 March 2012 22:31:57 Lamarque V. Souza wrote: > > WeatherEngine::~WeatherEngine() calls > > WeatherEngine::unloadIons(), which tries to use the invalid > > Plasma::DataEngineManager::self(). > > Since DataEngineManager uses K_GLOBAL_

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

Em Wednesday 21 March 2012, Thomas Lübking escreveu: > hook on QObject::destroyed() for the dataenginemanager (and flag > yourself "dontTry")? Didn't try it Unfortunately it also did not work :( WeatherEngine did not receive the signal, at least not before the crash. Thanks anywa

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

On Tuesday, March 20, 2012 22:31:57 Lamarque V. Souza wrote: > There is a crash in WeatherEngine (kde-workspace) triggered by the fact > that Plasma::DataEngineManager::self() (kdelib) is invalid when > plasma-{desktop,device} are exiting. WeatherEngine::~WeatherEngine() calls > WeatherEngine

Re: [GSoC] KWin colour management

On Wed, Mar 21, 2012 at 8:39 AM, Kai-Uwe Behrmann wrote: > Am 20.03.12, 21:17 +0100 schrieb Thomas Lübking: > >> Am 20.03.2012, 20:12 Uhr, schrieb Martin Graesslin : >> >>> A fully  color corrected compositor seems feasible to me >> >> I'm atm. not even sure about that. >> >> I might be utterly wr

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

On Tuesday 20 March 2012 22:31:57 Lamarque V. Souza wrote: > WeatherEngine::~WeatherEngine() calls > WeatherEngine::unloadIons(), which tries to use the invalid > Plasma::DataEngineManager::self(). Since DataEngineManager uses K_GLOBAL_STATIC internally, just use the isDestroyed() method to kno

Re: Need suggestion on how to fix the common crash in plasma-desktop (kdelibs related)

hook on QObject::destroyed() for the dataenginemanager (and flag yourself "dontTry")?

Re: [GSoC] KWin colour management

Am 20.03.12, 21:17 +0100 schrieb Thomas Lübking: Am 20.03.2012, 20:12 Uhr, schrieb Martin Graesslin : A fully color corrected compositor seems feasible to me I'm atm. not even sure about that. I might be utterly wrong, but my impression is that the xvidmode extension can correct screens (eg

Re: [GSoC] KWin colour management

Am 20.03.12, 20:12 +0100 schrieb Martin Graesslin: On Sunday 18 March 2012 20:01:01 Casian Andrei wrote: Hello, taking it to the KWin mailinglist as that's the relevant list in case this proposal would be accepted. First of all thanks for considering doing a GSoC project around KWin. I need y