Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
> On March 19, 2012, 12:17 a.m., Henry Miller wrote: > > In kauth/autotests/HelperTest.cpp The comment on line 57-68 should be > > reworded. In general when someone is told not to touch some lines they > > won't. You should be clear on why the code is that way. However saying > > "you don't w

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
> On March 18, 2012, 11:04 p.m., Stephen Kelly wrote: > > Nice, thanks and sorry for the noise, and thanks for making the branch. Np, hope you'll be able to have a quick look at it as well, it would be great :) - Dario --- This is an au

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11596 --- Nice, thanks and sorry for the noise, and thanks for making the

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
> On March 18, 2012, 10:55 p.m., Stephen Kelly wrote: > > Given that it does so many things, I wonder if it should be split into > > multiple patches. (I didn't fetch the branch - maybe you already have it in > > multiple patches) For examples, renaming the enums in one commit, making > > Acti

Re: Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/#review11594 --- Given that it does so many things, I wonder if it should be spl

Review Request: Make KAuth ready for frameworks + API Changes

2012-03-18 Thread Dario Freddi
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104337/ --- Review request for kdelibs, Kevin Ottens, David Faure, and Alexander Neundor

Re: Review Request: Remember current desktop when changing activity

2012-03-18 Thread makis marimpis
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104261/ --- (Updated March 18, 2012, 9:22 a.m.) Review request for KDE Runtime and Pla

Re: Review Request: Remember current desktop when changing activity

2012-03-18 Thread David Faure
> On March 16, 2012, 12:49 p.m., Ivan Čukić wrote: > > > > makis marimpis wrote: > Hm, i did that in order to restore the desktop ids from a previous run of > kamd (let's say, in case of log out). > > Ivan Čukić wrote: > You misunderstood, I don't mind saving it in the config file, I d