Re: Re: bugzilla situation

2012-02-23 Thread Martin Gräßlin
On Friday 24 February 2012 02:15:54 Sven Burmeister wrote: > Am Mittwoch, 22. Februar 2012, 19:00:26 schrieb Martin Gräßlin: > > Personally I'm not sure whether the MeeGo bugzilla can be compared to > > the KDE one (technical oriented vs. user oriented). From my personal > > experience (KWin bugtra

Review Request: kjs: Allow keywords as object propertynames

2012-02-23 Thread Bernd Buschinski
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104058/ --- Review request for kdelibs. Description --- For kjs, Allow keywords

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/#review10855 --- This review has been submitted with commit c27b939ac971f23e8cf

Re: Review Request: KImageCache optimization

2012-02-23 Thread Michael Pyne
> On Feb. 24, 2012, 1:16 a.m., Michael Pyne wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > The cache is unlocked here but temp is still pointing into its > > internals (as mentioned above)...

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 24, 2012, 1:16 a.m., Michael Pyne wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > The cache is unlocked here but temp is still pointing into its > > internals (as mentioned above)...

Re: Review Request: KImageCache optimization

2012-02-23 Thread Michael Pyne
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10858 --- The big issue is a race condition between finding an entry and

Re: bugzilla situation

2012-02-23 Thread Sven Burmeister
Am Mittwoch, 22. Februar 2012, 19:00:26 schrieb Martin Gräßlin: > Personally I'm not sure whether the MeeGo bugzilla can be compared to > the KDE one (technical oriented vs. user oriented). From my personal > experience (KWin bugtracker is felt > 90 % a user support forum) My claim is that most of

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

2012-02-23 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104051/ --- (Updated Feb. 24, 2012, 12:05 a.m.) Review request for KDE Runtime. Chan

Re: bugzilla situation

2012-02-23 Thread Sven Burmeister
Am Mittwoch, 22. Februar 2012, 12:38:38 schrieb Antonis Tsiapaliokas: > For e.x., someone is a core developer, someone is on release team or > someone else is a sysadmin and some others are taking critical decisions > about the feature of KDE. I don't think that neither of them was there > where h

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

2012-02-23 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104051/ --- (Updated Feb. 24, 2012, 12:37 a.m.) Review request for KDE Runtime. Chan

Re: bugzilla situation

2012-02-23 Thread Ben Cooksley
On Fri, Feb 24, 2012 at 11:41 AM, Kevin Ottens wrote: > On Thursday 23 February 2012 17:39:12 Trever Fischer wrote: >> Random, possibly entirely unhelpful suggestion: Perhaps using our redmine >> install of projects.kde.org for this kind of task tracking? I'd love to see >> p.k.o be used as someth

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote: > > kdeui/util/kimagecache.cpp, line 106 > > > > > > This fails to correctly handle palettized images. > > > > If we do not want to preserve image texts,

Re: bugzilla situation

2012-02-23 Thread Kevin Ottens
On Thursday 23 February 2012 17:39:12 Trever Fischer wrote: > Random, possibly entirely unhelpful suggestion: Perhaps using our redmine > install of projects.kde.org for this kind of task tracking? I'd love to see > p.k.o be used as something more of a central place for devs to get together > and c

Re: bugzilla situation

2012-02-23 Thread Trever Fischer
On Thursday, February 23, 2012 11:57:16 AM David Edmundson wrote: > > First of all, the bugzilla is supposed to be a communication tool between > > the user and the developer. > > Or is it? > > If I understand Martin correctly, he wants bugzilla to be "a list of > things broken in my app", not a

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 23, 2012, 7:23 p.m.) Review request for kdelibs, David Faure

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- (Updated Feb. 23, 2012, 7:21 p.m.) Review request for kdelibs, David Faure

Re: bugzilla situation

2012-02-23 Thread David Edmundson
> First of all, the bugzilla is supposed to be a communication tool between the > user and the developer. Or is it? If I understand Martin correctly, he wants bugzilla to be "a list of things broken in my app", not a communication tool for every user who wants to say something. In KDE Telepathy

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/#review10854 --- Ship it! Only one small spacing issue: kdeui/dialogs/kconfig

Re: Review Request: KImageCache optimization

2012-02-23 Thread Christoph Feck
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote: > > kdeui/util/kimagecache.cpp, line 106 > > > > > > This fails to correctly handle palettized images. > > > > If we do not want to preserve image texts,

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 8:56 p.m., Christoph Feck wrote: > > kdeui/util/kimagecache.cpp, line 106 > > > > > > This fails to correctly handle palettized images. > > > > If we do not want to preserve image texts,

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 7:57 p.m., Aaron J. Seigo wrote: > > kdecore/util/kshareddatacache.cpp, lines 1488-1496 > > > > > > looking at it again, it appears there is room for one more small > > optimization when destin

Re: Review Request: KImageCache optimization

2012-02-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10851 --- kdeui/util/kimagecache.cpp

Review Request: kdepasswd KCM: add option to remove the user image

2012-02-23 Thread Ralf Jung
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104054/ --- Review request for KDE Base Apps. Description --- Currently it is pos

Re: Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

2012-02-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104051/#review10849 --- it's +1 for me, but i'll leave the final call to someone that k

Re: Review Request: KImageCache optimization

2012-02-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10848 --- kdecore/util/kshareddatacache.cpp

Review Request: Make ksmserver not wait for kcminit if compiled with mobile profile

2012-02-23 Thread Lamarque Vieira Souza
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104051/ --- Review request for KDE Runtime. Description --- If kde-workspace is c

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 6:52 p.m., Aaron J. Seigo wrote: > > kdecore/util/kshareddatacache.cpp, line 1491 > > > > > > this needs a check on destination being not-null. e.g. if (destination > > && !temp.isNull()) above

Re: Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
> On Feb. 23, 2012, 6:33 p.m., Milian Wolff wrote: > > given that you have unit tests at hand, why not write a benchmark to get > > proper before/after numbers that show the impact of this patch? Right.. That's not exactly easy to "just" do since i would have to read a dir with images, insert

Re: Review Request: KImageCache optimization

2012-02-23 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10843 --- kdecore/util/kshareddatacache.cpp

Re: Review Request: KImageCache optimization

2012-02-23 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/#review10842 --- given that you have unit tests at hand, why not write a benchma

Review Request: KImageCache optimization

2012-02-23 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104052/ --- Review request for kdelibs, David Faure and Michael Pyne. Description

Re: Color Managing KDE

2012-02-23 Thread Jaroslav Reznik
- Original Message - > Fedora packages Oyranos since years. We were already discussing it within our Fedora KDE SIG as we're getting smashed between the colord (the rest of Fedora talks to) and oyranos (with KDE integration and as I heard being preferred by libre graphics people) gears.

Re: Re: Color Managing KDE

2012-02-23 Thread Alex Fiestas
On Wednesday, February 22, 2012 04:42:26 PM John Layt wrote: > I believe Alex Fiestas has expressed an interest in the past in developing > a KCM so he might be a good starting point. I did, but since Oyranos appeared I put it in hold, I still think that supporting colord is something we want but