Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ --- (Updated Feb. 21, 2012, 11:55 p.m.) Review request for kdelibs, Ben Cooksl

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

2012-02-21 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103909/ --- (Updated Feb. 21, 2012, 11:54 p.m.) Review request for kdelibs, Ben Cooksl

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

2012-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/#review10817 --- This review has been submitted with commit 576e13d355c34858e8a

Re: Bugzilla upgrade.

2012-02-21 Thread Milian Wolff
On Wednesday 22 February 2012 11:47:36 Ben Cooksley wrote: > On Wed, Feb 22, 2012 at 11:37 AM, Milian Wolff wrote: > > On Tuesday 21 February 2012 21:00:33 Tom Albers wrote: > >> Hi, > >> > >> Our bugzilla instance is an old version. We are preparing to upgrade it > >> to a recent version. > >>

Re: Bugzilla upgrade.

2012-02-21 Thread Ben Cooksley
On Wed, Feb 22, 2012 at 11:37 AM, Milian Wolff wrote: > On Tuesday 21 February 2012 21:00:33 Tom Albers wrote: >> Hi, >> >> Our bugzilla instance is an old version. We are preparing to upgrade it to a >> recent version. >> >> This will go in two stages. First we will perform a test upgrade. This w

Re: Bugzilla upgrade.

2012-02-21 Thread Milian Wolff
On Tuesday 21 February 2012 21:00:33 Tom Albers wrote: > Hi, > > Our bugzilla instance is an old version. We are preparing to upgrade it to a > recent version. > > This will go in two stages. First we will perform a test upgrade. This will > happen on Saturday Februari 25th. We will start at 8PM

Bugzilla upgrade.

2012-02-21 Thread Tom Albers
Hi, Our bugzilla instance is an old version. We are preparing to upgrade it to a recent version. This will go in two stages. First we will perform a test upgrade. This will happen on Saturday Februari 25th. We will start at 8PM CET. We expect little inpact, though during the database convers

Re: Review Request: New KPart extension for manupilating a browser engine's settings

2012-02-21 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/ --- (Updated Feb. 21, 2012, 6:35 p.m.) Review request for kdelibs and David Fa

Re: Review Request: New KPart extension for manupilating a browser engine's settings

2012-02-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/#review10807 --- khtml/khtml_ext.cpp

Re: Review Request: Make KFileWidget provide default filename even when the protocol doesn't support listing

2012-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103642/#review10805 --- This review has been submitted with commit 37ff4f63f23b36e6025

Re: Review Request: New KPart extension for manupilating a browser engine's settings

2012-02-21 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/ --- (Updated Feb. 21, 2012, 5:59 p.m.) Review request for kdelibs and David Fa

Re: Review Request: New KPart extension for manupilating a browser engine's settings

2012-02-21 Thread Dawit Alemayehu
> On Feb. 20, 2012, 7:16 p.m., David Faure wrote: > > kparts/htmlextension.h, line 274 > > > > > > Should this method return a bool maybe, so that the caller can find out > > that the part didn't support a specific

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103716/#review10796 --- This review has been submitted with commit e249c59263cd3a9bf59

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-02-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103716/#review10795 --- Ship it! kdeui/dialogs/kconfigdialog.h

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-02-21 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103716/ --- (Updated Feb. 21, 2012, 3:56 p.m.) Review request for kdelibs and David Fa

Re: Review Request: make folderview compile with Qt 4.7

2012-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/#review10793 --- This review has been submitted with commit 8de987c45a7fef0f1d3

Re: Review Request: make folderview compile with Qt 4.7

2012-02-21 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/#review10792 --- This review has been submitted with commit 39baedcf978ac34720c

Re: Review Request: New KPart extension for manupilating a browser engine's settings

2012-02-21 Thread David Faure
> On Feb. 20, 2012, 7:16 p.m., David Faure wrote: > > kparts/htmlextension.h, line 245 > > > > > > KParts::SettingsInterface is a bit generic for a name (it sounds like > > something that could apply to all parts),

Re: Review Request: make folderview compile with Qt 4.7

2012-02-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/#review10787 --- Ship it! Ship It! - David Faure On Feb. 20, 2012, 6:16 p.m.