[no subject]

set authenticate IXO13IqM set delivery off

Re: Review Request: New KPart extension for manupilating a browser engine's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/ --- (Updated Feb. 20, 2012, 11:22 p.m.) Review request for kdelibs and David F

Re: Review Request: New KPart extension for manupilating a browser engine's settings

> On Feb. 20, 2012, 7:16 p.m., David Faure wrote: > > kparts/htmlextension.h, line 245 > > > > > > KParts::SettingsInterface is a bit generic for a name (it sounds like > > something that could apply to all parts),

Re: Review Request: Fix signal/slot connections in kcmdolphinviewmodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104033/#review10776 --- This review has been submitted with commit cfde62cb32ca43ce73e

Re: Review Request: Fix signal/slot connections in kcmdolphinviewmodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104033/#review10775 --- This review has been submitted with commit b484b87376646420a2c

Re: Review Request: make folderview compile with Qt 4.7

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/#review10768 --- Isn't the Q_ASSERT in the wrong block? And I'd rather use a bo

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/#review10773 --- Ship it! A bit too many spaces inside parenthesis in new code,

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/ --- (Updated Feb. 20, 2012, 10:33 p.m.) Review request for kdelibs and David F

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/ --- (Updated Feb. 20, 2012, 10:22 p.m.) Review request for kdelibs and David F

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/ --- (Updated Feb. 20, 2012, 10:19 p.m.) Review request for kdelibs and David F

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/ --- (Updated Feb. 20, 2012, 10:17 p.m.) Review request for kdelibs and David F

Re: Review Request: Write to the correct xmlFile in KToolBar::Private::slotContextShowText()

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103812/ --- (Updated Feb. 20, 2012, 10:15 p.m.) Review request for kdelibs and David F

Re: Review Request: Fix KConfigDialogManager fails to handle subclasses of QComboBox with custom property

> On Feb. 10, 2012, 12:01 a.m., Christoph Feck wrote: > > Thanks Albert for looking at it. Not sure if I understand everything > > correctly, but what happens, when I have a subclass of Q/KComboBox, that > > does not have its own user property? > > > > I am considering the following possible c

Re: Review Request: New KPart extension for manupilating a browser engine's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/#review10771 --- khtml/khtml_ext.cpp

Re: Review Request: Fix signal/slot connections in kcmdolphinviewmodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104033/#review10769 --- Ship it! Thanks for the patch, looks fine! - Peter Penz On

Re: Review Request: make folderview compile with Qt 4.7

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/ --- (Updated Feb. 20, 2012, 6:16 p.m.) Review request for KDE Base Apps. Cha

Review Request: Fix signal/slot connections in kcmdolphinviewmodes

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104033/ --- Review request for KDE Base Apps and Peter Penz. Description --- The

Re: Review Request: make folderview compile with Qt 4.7

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/ --- (Updated Feb. 20, 2012, 5:18 p.m.) Review request for KDE Base Apps. Cha

Re: Review Request: New KPart extension for manupilating a browser engine's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/ --- (Updated Feb. 20, 2012, 5:11 p.m.) Review request for kdelibs and David Fa

Re: Please avoid noisy merge commits in frameworks

On Sunday 19 February 2012, Stephen Kelly wrote: > Laszlo Papp wrote: > >> Is there already something like that ? > > > > There is already something here: > http://community.kde.org/Frameworks/Git_Workflow#Local_branches_are_always_ > rebased.2C_remote_branches_never > > > Might be a good idea to

Re: Review Request: make folderview compile with Qt 4.7

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/#review10765 --- plasma/applets/folderview/actionoverlay.cpp

Review Request: make folderview compile with Qt 4.7

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104030/ --- Review request for KDE Base Apps. Description --- Currently, kde-base

Re: Review Request: New KPart extension for manupilating a browser engine's settings

> On Feb. 20, 2012, 10:58 a.m., David Faure wrote: > > Looks OK. Technically all this is related to HTML, it doesn't possibly > > apply to other kinds of kparts, so it could be made part of the existing > > HtmlExtension class, by adding a new interface for the settings-related > > methods. >

Re: Review Request: New KPart extension for manupilating a browser engine's settings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/#review10757 --- Ship it! Looks OK. Technically all this is related to HTML, it

Re: KPushButton and deprecated setIcon ?

On Sunday 19 February 2012 12:29:24 Martin Koller wrote: > Hi, > > I'm developing a new KDE application and use designer for the UI. > In designer I can set the icon for a KPushButton to a name in the field > "Theme" which results in a call to > QIcon icon(QIcon::fromTheme(QString::fromUtf

Re: Please avoid noisy merge commits in frameworks

On 19.02.12 17:49:59, Parker Coates wrote: > On Sun, Feb 19, 2012 at 11:58, Anne-Marie Mahfouf wrote: > > I guess I should get used to using gitk. > > This is slightly off topic, but with all this talk of gitk, I thought > it'd be a good time to recommend QGit [1]. It's an alternative git > histor

Re: Please avoid noisy merge commits in frameworks

söndagen den 19 februari 2012 14.36.07 skrev Stephen Kelly: > I was reviewing the changes in the frameworks branch from yesterday. > Something I noticed was that there are a lot of merge commits that don't > need to exist. Heh, sounds familiar, the same thing was brought up when Qt switched to