Re: Review Request: New KPart extension for manupilating a browser engine's settings

2012-02-18 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103973/ --- (Updated Feb. 18, 2012, 9:09 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/#review10720 --- Ship it! You may consider to add checking also CMAKE_C_IMPLICI

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103422/#review10718 --- Ship it! Ignore what I said before, the patch is the right thi

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Alexander Neundorf
On Saturday 18 February 2012, Modestas Vainius wrote: > > On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > > Actually this looks more like a cmake bug, the contents of > > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. What > > > version of cmake are you using ? > > >

Re: Review Request: Don't set an RPATH when installed into multiarch dir

2012-02-18 Thread Modestas Vainius
> On Dec. 16, 2011, 4:40 p.m., Alexander Neundorf wrote: > > Actually this looks more like a cmake bug, the contents of > > CMAKE_PLATFORM_IMPLICIT_LINK_DIRECTORIES seem to be quite wrong. > > What version of cmake are you using ? > > > > Felix Geyer wrote: > 2.8.5 (with this commit cerry-p