Re: Review Request: Port shutdown dialog to QML

2012-02-06 Thread Christoph Feck
> On Feb. 6, 2012, 9:38 p.m., Alexander Neundorf wrote: > > Good from my POV (cmake stuff). UI-wise looks also fine. Was there anything else we needed to do? If not, merge to master. Thanks, you rock! - Christoph --- This is an automat

Re: Review Request: Port shutdown dialog to QML

2012-02-06 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review10379 --- Ship it! Good from my POV (cmake stuff). - Alexander Neundorf

Re: Review Request: Prompt for the folder name when creating one in the sidebar bookmark module

2012-02-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103845/#review10374 --- This review has been submitted with commit ab4dfb4a5619dd36edb

Re: Review Request: Fix a VLC crash by delaying object deletion to avoid invalid access by QtDBus

2012-02-06 Thread David Faure
On Wednesday 01 February 2012 19:25:13 Dawit A wrote: > On Mon, Jan 30, 2012 at 4:48 AM, Thiago Macieira wrote: > > On Monday, 30 de January de 2012 08.05.50, Cristian Oneț wrote: > >> > Diffs > >> > - > >> > > >> > kio/bookmarks/kbookmarkmanager.cc d8a9cb7 > >> > kio/kio/fileundomanager.

Re: Re: [Kde-pim] Contact Aggregation [was: KDE Telepathy on its way to Extragear]

2012-02-06 Thread Jos Poortvliet
On Sunday, January 08, 2012 09:46:37 Daniele E. Domenichelli wrote: Heya, Ladies and gents - the reminder I promised to send: this weekend there will be a KDE PIM sprint in Osnabruck. Lets have a Telepath there to finish the contact aggregation discussion... BTW fun meeting some of you at FOS