Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Thiago Macieira
On Sunday, 22 de January de 2012 12.08.57, Stephen Kelly wrote: > Valentin Rusu wrote: > > Stephen Kelly wrote: > >> Kevin Ottens wrote: > >>> There's three main reasons for this rhythm: > >> * KAction/QAction stuff - Don't know what's needed. If QAction needs new > >> virtual method that would nee

Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Thiago Macieira
On Saturday, 21 de January de 2012 16.17.38, Stephen Kelly wrote: > * Thiagos stuff - I don't know. Thiago's stuff is: - new atomics (wasn't a KDE request): done, just waiting for integration because of stupid stuff like the copyright header not matching exactly what's expected and my inability

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-22 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103740/ --- (Updated Jan. 22, 2012, 6:18 p.m.) Review request for KDE Base Apps and Da

Re: Review Request: Moving tabs causes wrong tab to be highlighted upon reload

2012-01-22 Thread Dawit Alemayehu
> On Jan. 21, 2012, 8:43 p.m., Frank Reininghaus wrote: > > Your patch fixes the bug, but it also causes a regression: If the tab > > contains a split view, the tab title is not highlighted any more. It seems > > that the purpose of the function KonqFrameTabs::tabWhereActive() is to get > > th

Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Kevin Ottens
On Sunday 22 January 2012 12:17:45 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Saturday 21 January 2012 20:49:40 Stephen Kelly wrote: > >> Kevin Ottens wrote: > >> > On Saturday 21 January 2012 16:17:38 Stephen Kelly wrote: > >> >> Kevin Ottens wrote: > >> >> > There's three main reasons for

Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Stephen Kelly
Kevin Ottens wrote: > On Saturday 21 January 2012 20:49:40 Stephen Kelly wrote: >> Kevin Ottens wrote: >> > On Saturday 21 January 2012 16:17:38 Stephen Kelly wrote: >> >> Kevin Ottens wrote: >> >> > There's three main reasons for this rhythm: >> >> > * Qt 5.0 feature freeze is upon us now; >> >>

Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Stephen Kelly
Valentin Rusu wrote: > Stephen Kelly wrote: > >> Kevin Ottens wrote: >>> There's three main reasons for this rhythm: > >> * KAction/QAction stuff - Don't know what's needed. If QAction needs new >> virtual method that would need to be determined soon. Is anyone driving >> that? Again, needs subt

Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Kevin Ottens
On Saturday 21 January 2012 20:49:40 Stephen Kelly wrote: > Kevin Ottens wrote: > > On Saturday 21 January 2012 16:17:38 Stephen Kelly wrote: > >> Kevin Ottens wrote: > >> > There's three main reasons for this rhythm: > >> > * Qt 5.0 feature freeze is upon us now; > >> > * CMake 2.8.8 will be rel

Re: KDE Frameworks 5: Rhythm

2012-01-22 Thread Valentin Rusu
Stephen Kelly wrote: > Kevin Ottens wrote: >> There's three main reasons for this rhythm: > * KAction/QAction stuff - Don't know what's needed. If QAction needs new > virtual method that would need to be determined soon. Is anyone driving > that? Again, needs subtask here if it's going to happen:

Re: Review Request: #include

2012-01-22 Thread Martin Gräßlin
> On Jan. 22, 2012, 9:06 a.m., Erik Sigra wrote: > > Ship It! giving yourself a ship it kind of destroys the idea behind review board. >From my side there is a clear "NO" for everything KWin related. So why? Let's >consider for example atoms.h. I just used git blame and well the includes were

Re: Review Request: #include

2012-01-22 Thread Erik Sigra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103638/#review9996 --- Ship it! Ship It! - Erik Sigra On Jan. 15, 2012, 12:53 p.m.,