Re: hard-dep for Qt 4.8

On Thursday 19 January 2012 08.15.39 Martin Gräßlin wrote: > > As far as I know there are no forward incompatible behavior changes > > between Qt4.7 and Qt 4.8> I.e. AFAIK programming for 4.8 using 4.7 APIs > > but 4.8 behavior will give > > the same behavior on 4.7. > What comes to my mind is mul

Re: Re: hard-dep for Qt 4.8

On Wednesday 18 January 2012 12:53:25 Dario Freddi wrote: > Let's try to move the issue another way > round: can we think of a way in which we can safely make master depend > on new stuff without the risk of hurting these categories? Yes of course. First of all we have to think whether we introduce

Re: Re: hard-dep for Qt 4.8

On Wednesday 18 January 2012 10:26:13 Thomas Zander wrote: > On Wednesday 18 January 2012 10.11.58 todd rme wrote: > > But according to Martin, this isn't just about API changes, it is also > > about behavior changes. How do you expect people to know if they are > > relying on a Qt 4.8-specific be

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103719/#review9937 --- Ship it! Ship It! - Jeremy Paul Whiting On Jan. 17, 2012, 9:

Re: Review Request: Show the correct remote charset encoding in Konqueror's and Dolphin's "Set Remote Encoding" menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103730/#review9936 --- This review has been submitted with commit e824021d45a989ec7577

Re: Review Request: Show the correct remote charset encoding in Konqueror's and Dolphin's "Set Remote Encoding" menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103730/#review9935 --- This review has been submitted with commit 8f231bd08134f7b1870a

Re: Review Request: Show the correct remote charset encoding in Konqueror's and Dolphin's "Set Remote Encoding" menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103730/#review9929 --- Ship it! Thanks for the patch, looks fine! - Peter Penz On J

Re: Review Request: Show the correct remote charset encoding in Konqueror's and Dolphin's "Set Remote Encoding" menu

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103730/ --- (Updated Jan. 18, 2012, 7:03 p.m.) Review request for KDE Base Apps and Pe

Review Request: Show the correct remote charset in encoding in Konqueror and Dolphin.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103730/ --- Review request for KDE Base Apps and Peter Penz. Description --- The

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

> On Jan. 18, 2012, 3:39 p.m., Jeremy Paul Whiting wrote: > > Looks good to me as long as we aren't trying to keep BIC in frameworks. If > > we are, a duplicate method with KConfigSkeleton that simply calls this new > > method should be added to keep BC. We are definitely not keeping BC in fr

Re: Review Request: Append ".desktop" to generated link files to prevent them from being identified as something else

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103691/ --- (Updated Jan. 18, 2012, 6:26 p.m.) Review request for kdelibs and David Fa

Review Request: make Speller::spellCheckerFound() return true when the dict for the current language is found (important when there was no dict for default language)

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103729/ --- Review request for kdelibs. Description --- right now in cases when t

Re: Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103719/#review9922 --- Looks good to me as long as we aren't trying to keep BIC in fram

Re: Review Request: Append ".desktop" to generated link files to prevent them from being identified as something else

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103691/#review9921 --- kfile/knewfilemenu.cpp

Re: hard-dep for Qt 4.8

2012/1/18 Thomas Zander : > On Wednesday 18 January 2012 09.05.32 Dario Freddi wrote: >> > if you remember there are a lot of people using KDE that are not 'core' >> > developers. Typically they are one-time developers, they are artists, >> > they are translators etc > [] > >> That said, I am in fa

Re: hard-dep for Qt 4.8

On Wednesday 18 January 2012 10.11.58 todd rme wrote: > But according to Martin, this isn't just about API changes, it is also about > behavior changes. How do you expect people to know if they are relying on a > Qt 4.8-specific behavior? As far as I know there are no forward incompatible behavio

Re: hard-dep for Qt 4.8

On Wednesday 18 January 2012 09.05.32 Dario Freddi wrote: > > if you remember there are a lot of people using KDE that are not 'core' > > developers. Typically they are one-time developers, they are artists, > > they are translators etc [] > That said, I am in favor of moving to Qt 4.8 for a simpl

Re: hard-dep for Qt 4.8

On Wed, Jan 18, 2012 at 8:54 AM, Thomas Zander wrote: > On Wednesday 18 January 2012 06.35.57 Martin Gräßlin wrote: >> I didn't say that this is a reason. I wanted to highlight the problem of >> not  depending on 4.8 and everybody using 4.8. I'm not going to start >> reviewing code for "is this a

Re: hard-dep for Qt 4.8

2012/1/18 Thomas Zander : > On Wednesday 18 January 2012 06.35.57 Martin Gräßlin wrote: >> I didn't say that this is a reason. I wanted to highlight the problem of >> not  depending on 4.8 and everybody using 4.8. I'm not going to start >> reviewing code for "is this a Qt 4.8 change". > > Martin, >