Re: hard-dep for Qt 4.8

2012-01-17 Thread Thomas Zander
On Wednesday 18 January 2012 06.35.57 Martin Gräßlin wrote: > I didn't say that this is a reason. I wanted to highlight the problem of > not depending on 4.8 and everybody using 4.8. I'm not going to start > reviewing code for "is this a Qt 4.8 change". Martin, if you remember there are a lot of

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread Laszlo Papp
> On Jan. 17, 2012, 10:28 p.m., David Faure wrote: > > > "The kdeui module is unlikely welcome on mobile platforms" > > > > Why is this review about adding stuff to kdeui, then? I don't get it. > > Either you're using it or you're not using it -- or the real reason is > > core/gui split in you

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread Laszlo Papp
> On Jan. 17, 2012, 10:28 p.m., David Faure wrote: > > > "The kdeui module is unlikely welcome on mobile platforms" > > > > Why is this review about adding stuff to kdeui, then? I don't get it. > > Either you're using it or you're not using it -- or the real reason is > > core/gui split in you

Re: Re: hard-dep for Qt 4.8

2012-01-17 Thread Martin Gräßlin
On Tuesday 17 January 2012 17:06:26 Allen Winter wrote: > On Tuesday 17 January 2012 11:34:19 AM Martin Gräßlin wrote: > > On Friday 13 January 2012 10:06:10 Thiago Macieira wrote: > > > On Thursday, 12 de January de 2012 22.50.24, Ingo > > > =?ISO-8859-1?Q?Kl�cker?=> > > > > wrote: > > > > If you

Review Request: Use KCoreConfigSkeleton argument type where possible inside the KConfigDialog

2012-01-17 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103719/ --- Review request for kdelibs and Jeremy Paul Whiting. Description --- U

Re: Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103716/#review9903 --- > "The kdeui module is unlikely welcome on mobile platforms" Wh

Re: hard-dep for Qt 4.8

2012-01-17 Thread Allen Winter
On Tuesday 17 January 2012 11:34:19 AM Martin Gräßlin wrote: > On Friday 13 January 2012 10:06:10 Thiago Macieira wrote: > > On Thursday, 12 de January de 2012 22.50.24, Ingo =?ISO-8859-1?Q?Kl=F6cker?= > > wrote: > > > If you want developers to switch to Qt 4.8 to get the KDE code better > > > test

Re: Review Request: Port shutdown dialog to QML

2012-01-17 Thread Lamarque V. Souza
Em Tuesday 17 January 2012, Alexander Neundorf escreveu: > On Friday 06 January 2012, Alexander Neundorf wrote: > > On Friday 06 January 2012, Lamarque V. Souza wrote: > > > Em Thursday 05 January 2012, Alexander Neundorf escreveu: > > > > On Thursday 05 January 2012, Lamarque V. Souza wrote: > > >

Re: Review Request: Port shutdown dialog to QML

2012-01-17 Thread Alexander Neundorf
On Friday 06 January 2012, Alexander Neundorf wrote: > On Friday 06 January 2012, Lamarque V. Souza wrote: > > Em Thursday 05 January 2012, Alexander Neundorf escreveu: > > > On Thursday 05 January 2012, Lamarque V. Souza wrote: > > > > Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > >

Re: Re: hard-dep for Qt 4.8

2012-01-17 Thread Martin Gräßlin
On Friday 13 January 2012 10:06:10 Thiago Macieira wrote: > On Thursday, 12 de January de 2012 22.50.24, Ingo =?ISO-8859-1?Q?Kl=F6cker?= > wrote: > > If you want developers to switch to Qt 4.8 to get the KDE code better > > tested with this version of Qt then simply ask developers to do so. I > > s

Review Request: Replicate the existing KConfigDialog constructor and change one argument type

2012-01-17 Thread Laszlo Papp
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103716/ --- Review request for kdelibs and Jeremy Paul Whiting. Description --- U

Re: Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

2012-01-17 Thread Dario Freddi
Cool :) If no objections arise within the next hours, I'll commit the change 2012/1/17 Alex Fiestas : > On 01/17/2012 05:17 AM, Dario Freddi wrote: >> >> Howdy, >> >> this mail comes after a certain discussion on how to handle screen >> inhibition. At the moment, the aforementioned function leads

Re: Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

2012-01-17 Thread Alex Fiestas
On 01/17/2012 05:17 AM, Dario Freddi wrote: Howdy, this mail comes after a certain discussion on how to handle screen inhibition. At the moment, the aforementioned function leads to an inhibition of DPMS features and brightness handling - I propose to change that to include also Screensaver inhi

Re: [Kde-hardware-devel] Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

2012-01-17 Thread Sebastian Kügler
On Tuesday, January 17, 2012 05:17:25 Dario Freddi wrote: > this mail comes after a certain discussion on how to handle screen > inhibition. At the moment, the aforementioned function leads to an > inhibition of DPMS features and brightness handling - I propose to > change that to include also Scre