Re: Review Request: #include

2012-01-16 Thread Erik Sigra
> On Jan. 16, 2012, 1:48 p.m., David Faure wrote: > > What does "this improves buildability" mean? What was broken, in particular? > > > > I'm not objecting to the fix, I would just like to understand why it's > > necessary for you and not for everyone else ;) > > (different platform? compiler?

Proposal: have Solid::beginSuppressingScreenPowerManagement inhibit screensaver as well

2012-01-16 Thread Dario Freddi
Howdy, this mail comes after a certain discussion on how to handle screen inhibition. At the moment, the aforementioned function leads to an inhibition of DPMS features and brightness handling - I propose to change that to include also Screensaver inhibition, to provide a full hassle-free experien

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

2012-01-16 Thread Dirk Tilger
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103593/#review9870 --- While it definitely makes sense to make the KDE logout work, isn

Re: Review Request: Do not modify .fonts.conf when loading it. Now nothing is written before the user clicks apply or ok. Fixes Bug 105797.

2012-01-16 Thread Nikolaus Waxweiler
> On May 26, 2011, 2:03 p.m., Thomas Lübking wrote: > > > Would there even be any good alternative approaches? > > Yes, > > - properly read the fontconfig (including global settings) > > - only write settings actually touched by the user > > - have a checkbox to disable custom font configuration

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9866 --- This review has been submitted with commit 63c7ae800b22d0d9d6d5

Re: Review Request: #include

2012-01-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103638/#review9862 --- What does "this improves buildability" mean? What was broken, in

Re: Review Request: #include

2012-01-16 Thread Erik Sigra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103638/ --- (Updated Jan. 15, 2012, 12:53 p.m.) Review request for KDE Base Apps and H