Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-01-15 Thread Thiago Macieira
On Sunday, 15 de January de 2012 18.28.28, Martin Koller wrote: > qWarning is in QDBusDefaultConnection ctor > > > Did I place the warning in the wrong object in QtDBus? > > Or is there something *else* creating that connection? > > no, it's the call to QDBusConnection::sessionBus() > which creat

Re: Review Request: #include

2012-01-15 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103638/#review9843 --- As far as Oxygen is concerned, feel free to ship it. - Hugo Per

Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-01-15 Thread Martin Koller
On Sunday, 15. January 2012 13:18:58 Thiago Macieira wrote: > On Sunday, 15 de January de 2012 11.47.10, Martin Koller wrote: > >*if (!KUniqueApplication::start()) { > >* fprintf(stderr, "myAppName is already running!\n"); > >* return 0; > >*} > >*KUnique

Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-01-15 Thread Martin Koller
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103699/ --- (Updated Jan. 15, 2012, 5:28 p.m.) Review request for kdelibs. Changes -

Re: Review Request 103602

2012-01-15 Thread Ingomar Wesp
On 01/-10/-28163 08:59 PM, Ingomar Wesp wrote: > I don't mean to nag, but could someone please take another look at > . No longer necessary. Thanks for reviewing, David! -- Ingo

Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-01-15 Thread Thiago Macieira
On Sunday, 15 de January de 2012 11.47.10, Martin Koller wrote: >*if (!KUniqueApplication::start()) { >* fprintf(stderr, "myAppName is already running!\n"); >* return 0; >*} >*KUniqueApplication a; >*return a.exec(); > > So one of the very first

Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-01-15 Thread Martin Koller
On Sunday, 15. January 2012 11:47:10 Martin Koller wrote: > On Saturday, 14. January 2012 22:36:44 Thiago Macieira wrote: > > On Saturday, 14 de January de 2012 18.38.02, Martin Koller wrote: > > > --- > > > This is an automatically generated

Re: Review Request: Avoid QDBusConnection Qt warning message for each KUniqueApplication

2012-01-15 Thread Martin Koller
On Saturday, 14. January 2012 22:36:44 Thiago Macieira wrote: > On Saturday, 14 de January de 2012 18.38.02, Martin Koller wrote: > > --- > > This is an automatically generated e-mail. To reply, visit: > > http://git.reviewboard.kde.org/r/1036

Re: Review Request: #include

2012-01-15 Thread Erik Sigra
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103638/ --- (Updated Jan. 14, 2012, 6:16 p.m.) Review request for KDE Base Apps and Hu

Re: Review Request: fix the rect passed to kcapacitybar paint method

2012-01-15 Thread Alex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103669/#review9814 --- Ship it! Ship It! - Alex Fiestas On Jan. 12, 2012, 7:06 p.m.

Re: Review Request: KOpenWithDialog: Quote paths selected in the file dialog

2012-01-15 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103602/#review9818 --- Ship it! Yep we want to quote only paths from the file dialog,

[OT] Re: hard-dep for Qt 4.8

2012-01-15 Thread Ingo Klöcker
On Friday 13 January 2012, Shaun Reich wrote: > Some food for thought, as if this thread wasn't long enough...take a > look at how much discussion or rejection was given on the dependency > for Qt 4.7 back in 2010. > > i.e. nobody responded with objections or otherwise... > > http://lists.kde.org