Re: hard-dep for Qt 4.8

2012-01-12 Thread Hugo Pereira Da Costa
On 01/13/2012 12:12 AM, Hugo Pereira Da Costa wrote: Personally, I think making Qt4.8 mandatory for KDE4.8 without strong reasons to do so raises the barrier a bit too high for casual contributors willing to fix bugs. I personally find Qt harder to compile than kde and am quite reluctant to upd

Re: hard-dep for Qt 4.8

2012-01-12 Thread Hugo Pereira Da Costa
Personally, I think making Qt4.8 mandatory for KDE4.8 without strong reasons to do so raises the barrier a bit too high for casual contributors willing to fix bugs. I personally find Qt harder to compile than kde and am quite reluctant to update, just to be able to still fix bugs in oxygen. H

Re: hard-dep for Qt 4.8

2012-01-12 Thread Ingo Klöcker
On Thursday 12 January 2012, Marco Martin wrote: > On Thursday 12 January 2012, Martin Gräßlin wrote: > > Our distributions will ship 4.8 together with 4.8 and this > > combination might just be untested by the maintainers. So I > > strongly suggest that we make Qt 4.8 a dependency for master just

Re: Review Request: fix the rect passed to kcapacitybar paint method

2012-01-12 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103669/ --- (Updated Jan. 12, 2012, 7:06 p.m.) Review request for Dolphin, kdelibs and

Review Request: Filter user input when creating a shortcut link to a URL location

2012-01-12 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103684/ --- Review request for kdelibs. Description --- If a user enters, www.kde

Re: Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

2012-01-12 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103682/#review9772 --- I'm not the maintainer of the code, but the patch looks good. De

Re: hard-dep for Qt 4.8

2012-01-12 Thread Marco Martin
On Thursday 12 January 2012, Martin Gräßlin wrote: > Our distributions will ship 4.8 together with 4.8 and this combination > might just be untested by the maintainers. So I strongly suggest that we > make Qt 4.8 a dependency for master just to get the code tested and fixed > before distros use it.

Review Request: Fix capacity text in places panel (and possibly unwanted spin-up behavior)

2012-01-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103682/ --- Review request for Dolphin, kdelibs and Solid. Description --- I only

Re: Re: hard-dep for Qt 4.8

2012-01-12 Thread Shaun Reich
On Thu, Jan 12, 2012 at 9:09 AM, Martin Gräßlin wrote: > I don't think there is a feature which is a good reason, but a "bug". I am > quite sure that there are still some issues around q_delete_all and the other > changes in Qt 4.8 causing regressions. > Our distributions will ship 4.8 together

Re: Re: hard-dep for Qt 4.8

2012-01-12 Thread Martin Gräßlin
On Wednesday 11 January 2012 17:38:11 Allen Winter wrote: > On Wednesday 11 January 2012 11:47:00 AM Shaun Reich wrote: > > Prompting motion for making Qt 4.8 a hard dependency for KDE > > 4.9/master. Currently kde-baseapps/plasma/folderview does not build > > against 4.7 due to an (albeit minor) a

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-12 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9767 --- This review has been submitted with commit 3c870e7d094c96afa322