Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-09 Thread Johannes Huber
> On Jan. 9, 2012, 9:24 p.m., Alexander Neundorf wrote: > > Looks good now. Note i cant ship it by myself, have no developer application. - Johannes --- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.

Re: Review Request: Prevent Konqueror crash when the location toolbar is disabled

2012-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103663/#review9681 --- This review has been submitted with commit 261ffb5ed440d98982c0

Re: Review Request: Prevent Konqueror crash when the location toolbar is disabled

2012-01-09 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103663/#review9680 --- This review has been submitted with commit b21b16103a643d0a1b4c

Re: Review Request: Prevent Konqueror crash when the location toolbar is disabled

2012-01-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103663/#review9677 --- Ship it! Looks good, thanks for the fix. konqueror/src/konqma

Re: Review Request: Fix FindXine.cmake to use pkg-config instead of xine-config

2012-01-09 Thread Alexander Neundorf
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103631/#review9676 --- Ship it! Looks good now. - Alexander Neundorf On Jan. 8, 201

Review Request: Prevent Konqueror crash when the location toolbar is disabled

2012-01-09 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103663/ --- Review request for KDE Base Apps. Description --- The attached patch