Re: Review Request: Port shutdown dialog to QML

Em Wednesday 04 January 2012, Alexander Neundorf escreveu: > On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: > > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > > > ksmserver/CMakeLists.txt, line 57 > > > >

Re: ktouchpadenabler moved to kdereview

On Thursday, January 05, 2012 12:17:33 AM Albert Astals Cid wrote: > El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: > > On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: > > > El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va > > escriure: >

Re: ktouchpadenabler moved to kdereview

On Thursday 05 January 2012 00:17:33 Albert Astals Cid wrote: > El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: > > kglobalaccel seems quite suitable indeed, no? > > It would, if Qt had a key for XF86XK_TouchpadToggle > [...] > Albert Bummer, you are right, didn't think

Re: libmm-qt and libnm-qt still in KDE Review

Em Wednesday 04 January 2012, Ben Cooksley escreveu: > Hi all, > > Just doing a little spring cleaning of KDE Review and I noticed that > libmm-qt and libnm-qt are still there. What was the final decision on > where they are going to be moved? Good question. Does anybody object to moving

Re: ktouchpadenabler moved to kdereview

Em Wednesday 04 January 2012, Albert Astals Cid escreveu: > El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: > > On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: > > > El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va > > escriure: > > > > On

Re: ktouchpadenabler moved to kdereview

On Thursday 05 January 2012 00:17:33 Albert Astals Cid wrote: > khotkeys is already a kded module, so there won't be no more processes > waking up now than before by adding a new kded module. Ah, OK. > > kglobalaccel seems quite suitable indeed, no? > > It would, if Qt had a key for XF86XK_Touc

Re: Review Request: Fix KConfigIniBackend::isWritable() when the parent directory doesn't exist

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103577/#review9557 --- This review has been submitted with commit f8f07161e04f8ffececa

Re: ktouchpadenabler moved to kdereview

El Dimecres, 4 de gener de 2012, a les 23:40:26, David Faure va escriure: > On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: > > El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: > > > On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: > > > > M

Re: ktouchpadenabler moved to kdereview

El Dimecres, 4 de gener de 2012, a les 20:15:27, Thomas Lübking va escriure: > Am 04.01.2012, 18:51 Uhr, schrieb Albert Astals Cid : > > I don't really see any point in doing that, nothing can be shared > > between them > > and the existing ktouchpadenabler so instead of one simple codebase (166 >

libmm-qt and libnm-qt still in KDE Review

Hi all, Just doing a little spring cleaning of KDE Review and I noticed that libmm-qt and libnm-qt are still there. What was the final decision on where they are going to be moved? Regards, Ben

Re: ktouchpadenabler moved to kdereview

On Wednesday 04 January 2012 18:51:44 Albert Astals Cid wrote: > El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: > > On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: > > > My little kded daemon that listens to XF86XK_TouchpadToggle and > > > enables disabl

Re: Review Request: Hacky workaround for https://bugs.kde.org/show_bug.cgi?id=228005

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103593/#review9556 --- ksmserver/shutdown.cpp

Re: Review Request: Port shutdown dialog to QML

On Wednesday 04 January 2012, Lamarque Vieira Souza wrote: > > On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > > ksmserver/CMakeLists.txt, line 57 > > > > > ne57> > > > > > > no variable for kdeclarative? > > >

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 7:19 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > ksmserver/CMakeLists.txt, line 57 > > > > > > no variable for kdeclarative? > > Lamarque Vieira Souza wrote: > There is one in shutdowndlg.cpp, in KSMSh

Re: ktouchpadenabler moved to kdereview

Am 04.01.2012, 18:51 Uhr, schrieb Albert Astals Cid : I don't really see any point in doing that, nothing can be shared between them and the existing ktouchpadenabler so instead of one simple codebase (166 lines with 20 of headers) you end up adding more complexity to existing programs (pro

Re: Review Request: kcm-grub2

On Wed, Jan 4, 2012 at 20:46, Albert Astals Cid wrote: > El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va > escriure: >> On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote: >> > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va >> > >> > escriure: >>

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > ksmserver/CMakeLists.txt, line 57 > > > > > > no variable for kdeclarative? > > Lamarque Vieira Souza wrote: > There is one in shutdowndlg.cpp, in KSMSh

Re: Review Request: kcm-grub2

El Dimecres, 4 de gener de 2012, a les 20:32:11, Konstantinos Smanis va escriure: > On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote: > > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va > > > > escriure: > >> Hi, > >> > >> kcm-grub2 has been in kdereview for months.

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 6:41 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: kcm-grub2

On Wed, Jan 4, 2012 at 20:15, Albert Astals Cid wrote: > El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va > escriure: >> Hi, >> >> kcm-grub2 has been in kdereview for months. It would be great if it >> could be moved back or forth. I am planning a new release soon, I >> would

Re: Review Request: kcm-grub2

El Dimarts, 3 de gener de 2012, a les 16:47:51, Konstantinos Smanis va escriure: > Hi, > > kcm-grub2 has been in kdereview for months. It would be great if it > could be moved back or forth. I am planning a new release soon, I > wouldn't like to abuse kdereview. If noone raised extra comments an

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 6:08 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 4:58 p.m., Christoph Feck wrote: > > ksmserver/themes/default/main.qml, line 166 > > > > > > Note that pointSize != pixelSize. With a high DPI display, a 10 pt font > > could be 30 pixels large

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: ktouchpadenabler moved to kdereview

El Dimecres, 4 de gener de 2012, a les 01:53:13, Christoph Feck va escriure: > On Wednesday 04 January 2012 00:28:11 Albert Astals Cid wrote: > > My little kded daemon that listens to XF86XK_TouchpadToggle and > > enables disables the touchpad accordingly has been moved to > > kdereview. > > > > M

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review9543 --- This review has been submitted with commit 1104fc8855770e0d75f4

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 5:03 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/#review9537 --- ksmserver/themes/default/main.qml

Re: Review Request: Port shutdown dialog to QML

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103621/ --- (Updated Jan. 4, 2012, 3:57 p.m.) Review request for KDE Base Apps and KDE

Re: Review Request: Port shutdown dialog to QML

> On Jan. 4, 2012, 12:24 a.m., Christoph Feck wrote: > > Very nice work, one of the things where QML makes sense. > > > > Are there any i18n string regressions? If possible, I would see it in 4.8 > > (maybe not 4.8.0, but backport sometimes later, after it has received > > testing in master),

Re: Review Request: Port shutdown dialog to QML

> On Jan. 3, 2012, 9:38 p.m., Albert Astals Cid wrote: > > Some of your QtQuick imports are 1.0 and some others 1.1, i guess some > > consistency there would be nice > > > > You need to extract the i18n messages from the qml files > > > > And having the keyboard not working seems like a huge r

Re: Review Request: removed misplaced line formatting control character in documentation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103623/#review9524 --- This review has been submitted with commit dce1153a74314542bb00

Re: Review Request: removed misplaced line formatting control character in documentation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103623/#review9523 --- Ship it! Looks good, will commit, thanks. - Eike Hein On Jan

Review Request: removed misplaced line formatting control character in documentation

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103623/ --- Review request for kdelibs. Description --- removed misplaced line fo

Review Request: kcm-grub2

Hi, kcm-grub2 has been in kdereview for months. It would be great if it could be moved back or forth. I am planning a new release soon, I wouldn't like to abuse kdereview. Regards, Konstantinos