Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/ --- (Updated Jan. 3, 2012, 5:51 a.m.) Review request for kdelibs. Changes --

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103610/ --- (Updated Jan. 3, 2012, 1:43 a.m.) Review request for kdelibs. Changes --

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

> On Jan. 2, 2012, 10:50 p.m., David Faure wrote: > > kparts/browseropenorsavequestion.cpp, line 287 > > > > > > I don't get what this call changes, here (with no filename passed to > > the method). It resolves al

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

On Mon, Jan 2, 2012 at 5:57 PM, Thiago Macieira wrote: > On Monday, 2 de January de 2012 22.18.45, Thomas Baumgart wrote: >> Hi, >> >> on Monday 02 January 2012 22:08:48 Thiago Macieira wrote: >> > On Monday, 2 de January de 2012 18.53.12, Dawit Alemayehu wrote: >> > > Diff: http://git.reviewboard

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

On Monday, 2 de January de 2012 22.18.45, Thomas Baumgart wrote: > Hi, > > on Monday 02 January 2012 22:08:48 Thiago Macieira wrote: > > On Monday, 2 de January de 2012 18.53.12, Dawit Alemayehu wrote: > > > Diff: http://git.reviewboard.kde.org/r/103610/diff/diff > > > > 404 - Page does not exist

Re: Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/#review9484 --- kparts/browseropenorsavequestion.cpp

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

Hi, on Monday 02 January 2012 22:08:48 Thiago Macieira wrote: > On Monday, 2 de January de 2012 18.53.12, Dawit Alemayehu wrote: > > Diff: http://git.reviewboard.kde.org/r/103610/diff/diff > > 404 - Page does not exist > > Reviewboard broken? Try https://git.reviewboard.kde.org/r/103610/diff/

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

El Dilluns, 2 de gener de 2012, a les 19:08:48, Thiago Macieira va escriure: > On Monday, 2 de January de 2012 18.53.12, Dawit Alemayehu wrote: > > Diff: http://git.reviewboard.kde.org/r/103610/diff/diff > > 404 - Page does not exist > > Reviewboard broken? For ages, the sent mails have an extra

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

On Monday, 2 de January de 2012 18.53.12, Dawit Alemayehu wrote: > Diff: http://git.reviewboard.kde.org/r/103610/diff/diff 404 - Page does not exist Reviewboard broken? -- Thiago Macieira - thiago (AT) macieira.info - thiago (AT) kde.org Software Architect - Intel Open Source Technology Cent

Re: Review Request: Fix for stale permissions information in properties dialog

> On Dec. 28, 2011, 7:37 a.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1078 > > > > > > Yes, but changing permissions is only one case for ending up here. The > > most common case is that KDirWatch (in

Re: Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103610/ --- (Updated Jan. 2, 2012, 8:44 p.m.) Review request for kdelibs. Changes --

Review Request: Factor out and reuse the code that guesses mime-type from filename

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103617/ --- Review request for kdelibs. Description --- * Factored out the code t

Review Request: Use the safer Qt's version of string functions in kio_ftp

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103616/ --- Review request for kdelibs. Description --- - Use the safer Qt versio

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 2:00 PM, Mark wrote: > What i meant is: how do you run that bash function? > I have no clue for bash functions and how they work. So for example do i > need to do: "runmaster() dolphin"? > Yeah, i really have no clue! You open a new shell, you type in 'runmaster'. Now your

Re: Review Request: Do not emit KEditToolBar::newToolBarConfig twice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103579/#review9476 --- This review has been submitted with commit 74a7bf7dbd530678bb93

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 7:13 PM, Shaun Reich wrote: > On Mon, Jan 2, 2012 at 12:38 PM, Mark wrote: > > Do you also have a run example for any kde app? > > Hm, for any kde app? The script snippet I gave you can run anything, > provided you point the vars to the right path. It even uses a > differe

Review Request: Fix for SSL handeshake failure in TcpSlaveBase due to server not supporting SSL compression

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103610/ --- Review request for kdelibs. Description --- The attached patch addres

Re: Review Request: Do not emit KEditToolBar::newToolBarConfig twice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103579/#review9475 --- Ship it! Nice solution :-) kdeui/dialogs/kedittoolbar.cpp

Re: Review Request: Do not show path info the Properties dialog edit box

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103594/#review9474 --- This review has been submitted with commit 201fe150f0aa5c58d71c

Re: Review Request: Do not add two actions with the same name to Konqueror's actionCollection.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103590/#review9473 --- This review has been submitted with commit f86eb0531a3dfe65403c

Re: Review Request: Do not add two actions with the same name to Konqueror's actionCollection.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103590/#review9472 --- This review has been submitted with commit c0341d4479830d3e47b8

Re: Review Request: Do not emit KEditToolBar::newToolBarConfig twice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103579/ --- (Updated Jan. 2, 2012, 6:25 p.m.) Review request for kdelibs. Changes --

Re: Review Request: Do not emit KEditToolBar::newToolBarConfig twice

> On Jan. 2, 2012, 10:28 a.m., David Faure wrote: > > This makes _k_slotOK call reject() instead of accept(), which might create > > issues in the users of the dialog. > > > > I think a different fix is needed, usually this is done via a bool "dirty", > > i.e. "there are changes to be saved",

Re: Review Request: Do not randomly change the state of Konqueror's Bookmark toolbar when users modify toolbar settings.

> On Jan. 2, 2012, 10:47 a.m., David Faure wrote: > > Assuming this doesn't hide the bar when it shouldn't (on startup, or when > > the user asks to see it), this looks ok. AFAICT, it does not. If you turn on the bookmark toolbar, close konqueror and start it again, the bookmark is visible.

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 12:38 PM, Mark wrote: > Do you also have a run example for any kde app? Hm, for any kde app? The script snippet I gave you can run anything, provided you point the vars to the right path. It even uses a different KDEHOME, so that configuration files won't get touched from t

Re: Review Request: Fix KConfigIniBackend::isWritable() when the parent directory doesn't exist

> On Jan. 2, 2012, 10:12 a.m., David Faure wrote: > > Looks good. A bit hard to read, but that's QDir/QFileInfo's fault, not > > yours :) > > > > You don't seem to have a kde contributor account, do you want to get one, > > or should I commit this for you? I expect to come up with patches onl

Re: Review Request: one assigment and one duplicated test

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103599/#review9460 --- This review has been submitted with commit a381834caeb0a4182efe

Re: Review Request: Do not show path info the Properties dialog edit box

> On Jan. 2, 2012, 11:05 a.m., David Faure wrote: > > I don't like it very much (the whole find file stuff and its handling of > > relative paths is messy - I blame myself), but I can't think of a better > > way for now, nor of a case where we wouldn't want this. > > > > Maybe split it in two

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 6:26 PM, Shaun Reich wrote: > On Mon, Jan 2, 2012 at 11:59 AM, Mark wrote: > > That is completely the opposite of what was suggested to me in the last > few > > months of the kde svn days. Back then it was specifically suggested to > use > > a separate user for kde develop

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 5:59 PM, Mark wrote: > On Mon, Jan 2, 2012 at 12:59 AM, Shaun Reich wrote: > >> Honestly, running a separate user for it just makes everything more a >> pain than it should be.The better way is to just run it under your >> user but use different environment variables when y

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 11:59 AM, Mark wrote: > That is completely the opposite of what was suggested to me in the last few > months of the kde svn days. Back then it was specifically suggested to use > a separate user for kde developing stuff. Don't know who suggested it. Yes, well...it's changed

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Mon, Jan 2, 2012 at 12:59 AM, Shaun Reich wrote: > Honestly, running a separate user for it just makes everything more a > pain than it should be.The better way is to just run it under your > user but use different environment variables when you want to run > master apps. Your crash is likely c

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Monday, January 02, 2012 13:57:57 Sebastian Kügler wrote: > On Monday, January 02, 2012 00:49:17 Mark wrote: > > I have everything in .profile > > .profile is for interactive shells. source ~/.profile in your ~/.kde/env > in order to make it known to apps started from non-interactive shells, >

Re: Can we please have an updated and confirmed working "build KDE from source as separate user"?

On Monday, January 02, 2012 00:49:17 Mark wrote: > I have everything in .profile .profile is for interactive shells. source ~/.profile in your ~/.kde/env in order to make it known to apps started from non-interactive shells, better yet, put your environmental vars in there, and not in your login

Re: Review Request: one assigment and one duplicated test

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103599/#review9437 --- Ship it! Ship It! - David Faure On Dec. 31, 2011, 11:33 a.m.

Re: Review Request: Do not show path info the Properties dialog edit box

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103594/#review9435 --- Ship it! I don't like it very much (the whole find file stuff a

Re: Review Request: Do not add two actions with the same name to Konqueror's actionCollection.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103590/#review9432 --- Ship it! OK. I guess we shouldn't even offer konsolepart in the

Re: Review Request: Do not randomly change the state of Konqueror's Bookmark toolbar when users modify toolbar settings.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103580/#review9430 --- Ship it! Assuming this doesn't hide the bar when it shouldn't (

Re: Review Request: Do not emit KEditToolBar::newToolBarConfig twice

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103579/#review9429 --- This makes _k_slotOK call reject() instead of accept(), which mi

Re: Changing HEAD in kdelibs.git

On Monday 02 January 2012 07:42:51 Eike Hein wrote: > Does anyone object to sysadmin changing HEAD in > kdelibs.git to point to the 4.8 branch, so that a > simple clone of the repo results in a checkout of > that branch? No objection, as long as you remember to keep that up-to-date :-) > With kde

Re: Review Request: Fix KConfigIniBackend::isWritable() when the parent directory doesn't exist

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103577/#review9428 --- Ship it! Looks good. A bit hard to read, but that's QDir/QFileI

Re: Changing HEAD in kdelibs.git

On 1/2/2012 9:24 AM, Alex Fiestas wrote: Somehow I skip the thread where the creation of the 4.8 branch was discussed (I'm guessing it was a long thread?) Anyway I was unable to build kde-workspace until somebody told me about the new branch :/ was it announced anywhere? I hit the same problem.

Re: Changing HEAD in kdelibs.git

On 01/02/2012 07:42 AM, Eike Hein wrote: Does anyone object to sysadmin changing HEAD in kdelibs.git to point to the 4.8 branch, so that a simple clone of the repo results in a checkout of that branch? Somehow I skip the thread where the creation of the 4.8 branch was discussed (I'm guessing it