Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103524/#review9343 --- This review has been submitted with commit fd8a97bc0865fee85ca5

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

On Onsdag den 28. december 2011, Dawit Alemayehu wrote: > > I disagree. Basically, if a user associates konqueror with anything else > > himself, your patch would disregard that and just fire up firefox. > > Yes exactly. The user consciously choose to do that. Why should we not > honor that choice

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103524/#review9340 --- This review has been submitted with commit b7a55b94873a8731a838

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > konqueror/client/kfmclient.cpp, line 386 > > > > > > The code later on uses "new KRun" for the case of a user-defined > > browser, given that KRun can handle th

Re: Review Request: Fix for stale permissions information in properties dialog

> On Dec. 28, 2011, 7:37 a.m., David Faure wrote: > > kio/kio/kdirlister.cpp, line 1078 > > > > > > Yes, but changing permissions is only one case for ending up here. The > > most common case is that KDirWatch (in

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > konqueror/client/kfmclient.cpp, line 386 > > > > > > The code later on uses "new KRun" for the case of a user-defined > > browser, given that KRun can handle th