Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-24 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103524/ --- (Updated Dec. 24, 2011, 10:16 p.m.) Review request for KDE Base Apps and D

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-24 Thread Dawit Alemayehu
> On Dec. 24, 2011, 8:38 a.m., David Faure wrote: > > FTP requires a file manager, not a web browser. You get a much better > > experience with a FTP url in e.g. dolphin than in firefox, IMHO. Using web > > browsers for FTP urls is a historic relic from before proper network > > transparency i

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Thomas Lübking
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Askar Safin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Askar Safin
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Review Request: Fïx two little bugs: one with default contrast settings and one with plasma popup alignment.

2011-12-24 Thread Nikita Churaev
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103529/ --- Review request for kdelibs and Plasma. Description --- Contrast bug:

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Thomas Lübking
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread David Faure
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread Thomas Lübking
> On Dec. 24, 2011, 8:28 a.m., David Faure wrote: > > This seems like a dangerous change to me. > > > > With it, you could run multiple instance of "kmail --nofork", and they > > would step on each other's toes. The whole point of kuniqueapplication (in > > normal apps, not in konsole), is to

Re: Review Request: Make kfmclient honor the user configured browser settings for local resources

2011-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103524/#review9228 --- FTP requires a file manager, not a web browser. You get a much b

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread David Faure
> On Dec. 23, 2011, 11:59 a.m., Askar Safin wrote: > > Ship It! I don't think you're supposed to "Ship it" your own change, the point of reviewboard is to get reviews from others :-) - David --- This is an automatically generated e-mai

Re: Review Request: "konsole --nofork" crashes when started not from terminal

2011-12-24 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/10/#review9226 --- This seems like a dangerous change to me. With it, you could ru