Review Request: Make the action names of KRecentFilesAction not be extremely long

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103360/ --- Review request for kdelibs and David Faure. Description --- Cut the n

Re: Requesting freeze exception for JtG

On Thursday 08 December 2011 16:56:16 David Faure wrote: > khelpmenu seems to have been ported from qt3 without much thinking, the > actions in menu() could just use kstandardaction too, instead of > duplicating the action details... but that's for frameworks 5 :) Hmm, actually that's just imple

Re: Review Request: Fix KCategorizedView race

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/ --- (Updated Dec. 8, 2011, 6:04 p.m.) Review request for kdelibs, Rafael Ferná

Re: kactivities update

On Thursday 08 December 2011 17.12.05 Kevin Kofler wrote: > Aaron J. Seigo wrote: > > yes, i skipped the details. done properly it should be linking > > libkactivities. this is an acceptable short term work-around given it's > > in a branch, while doing it "right" requires the modularization to be

Re: Review Request: GSoC: Errors handling during file transfer.

> On Nov. 17, 2011, 2:33 p.m., David Faure wrote: > > > > David Faure wrote: > Cyril, can you rebase your changes on top of the kdelibs frameworks > branch, compile, and commit there? > > Cyril Oblikov wrote: > Hi David. > > I'm currently working on this dialog together with B

Re: Review Request: make KFileWidget keep current extension if possible

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102986/#review8808 --- Thx, looks better. Just one comment for code readability, feel f

Re: Review Request: Allow the user to choose sftp or fish on knetattach

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103199/#review8804 --- Ship it! Ship It! - David Faure On Nov. 21, 2011, 8:11 p.m.,

Re: Right location for test config files?

On Monday 21 November 2011 20:27:28 Andriy Rysin wrote: > In regards to defect below, what's the right location for some xml files > I use in keyboard daemon tests? Currently the files I have is to test > the code for parsing /usr/share/X11/xkb/rules/evdev.xml but some others > could be added later

Re: Review Request: Fix KCategorizedView race

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8803 --- kdeui/itemviews/kcategorizedview.cpp

Re: Review Request: Fix KCategorizedView race

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8802 --- - Thomas Lübking On Dec. 8, 2011, 6:04 p.m., Thomas Lübking wr

Re: kactivities update

Aaron J. Seigo wrote: > yes, i skipped the details. done properly it should be linking > libkactivities. this is an acceptable short term work-around given it's in > a branch, while doing it "right" requires the modularization to be > complete for at least libkactivities dependencies. Or it'd requ

Re: kactivities update

Aaron J. Seigo wrote: > yes, i skipped the details. done properly it should be linking > libkactivities. this is an acceptable short term work-around given it's in > a branch, while doing it "right" requires the modularization to be > complete for at least libkactivities dependencies. Or it'd requ

Re: Review Request: Fix KCategorizedView race

Am Thu, 8 Dec 2011 07:59:43 -0800 schrieb Tomaz Canabrava : > What about jaime patch? yeah, static policies work - we know that ;-) This one is quite different (recursion, not race - though maybe both), from the first rough look there seem two recursions, one direct (easy to catch) and one throug

Re: Review Request: Fix KCategorizedView race

On Thu, Dec 8, 2011 at 2:33 AM, Thomas Lübking wrote: >This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/103335/ > > On December 6th, 2011, 6:39 p.m., *Commit Hook* wrote: > > This review has been submitted with commit > 08325ba32b72326030004cc2843

Re: Review Request: Fix KCategorizedView race

> On Dec. 6, 2011, 6:39 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking to branch > > KDE/4.7. > > Christoph Feck wrote: > This commit causes systemsettings to go into endless recursion, see > http://pr

Re: Requesting freeze exception for JtG

On Wednesday 23 November 2011 00:28:07 Pau Garcia i Quiles wrote: > > 1) Changes to ui_standards.rc > > > > This is a high-risk change. It affects every application that uses > > XMLGUI and KParts plugins. I did quite a lot of work in this area in > > KDE 3.x and I know that changes to this file c

Re: Review Request: Fix KCategorizedView race

The new endless loop (causing a stack overflow here when I resize systemsettings view) this time is in: QListView::resizeEvent(QResizeEvent *e) that calls QAbstractItemView::resizeEvent(e); QAbstractItemView::resizeEvent(QResizeEvent *event) that calls KCategorizedView::updateGeometries(); QFra

Re: Review Request: Fix KCategorizedView race

> On Dec. 6, 2011, 6:39 p.m., Commit Hook wrote: > > This review has been submitted with commit > > 08325ba32b72326030004cc28430431193d82fc2 by Thomas Lübking to branch > > KDE/4.7. This commit causes systemsettings to go into endless recursion, see http://privatepaste.com/0e43ad214c zemo on