Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote: > > I have an account called shaforo. i could push to kdepimlibs with it, but i > > couldn't push to kdelibs. is it because of lack of permissions? > > Alexander Potashev wrote: > You need to clone the `kdelibs` repo from `g...@git.kde

Re: Review Request: [PATCH] Change HTML thumbnail generator to kdewebkit

2011-12-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/#review8774 --- This review has been submitted with commit 15481be78c527760fac1

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Aaron J. Seigo
> On Dec. 6, 2011, 2:07 p.m., Aaron J. Seigo wrote: > > Ship It! > > Thomas Lübking wrote: > What's the policy for merging things into the frameworks branch? > - Merge? > - Cherry-pick? > - Have someone else do it anyway? we merge KDE/4.7 into frameworks every so often. i did it

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Albert Astals Cid
> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote: > > I have an account called shaforo. i could push to kdepimlibs with it, but i > > couldn't push to kdelibs. is it because of lack of permissions? > > Alexander Potashev wrote: > You need to clone the `kdelibs` repo from `g...@git.kde

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Thomas Lübking
> On Dec. 6, 2011, 2:07 p.m., Aaron J. Seigo wrote: > > Ship It! What's the policy for merging things into the frameworks branch? - Merge? - Cherry-pick? - Have someone else do it anyway? - Thomas --- This is an automatically generated

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8765 --- This review has been submitted with commit 08325ba32b7232603000

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Alexander Potashev
> On Dec. 6, 2011, 5:58 p.m., Nick Shaforostoff wrote: > > I have an account called shaforo. i could push to kdepimlibs with it, but i > > couldn't push to kdelibs. is it because of lack of permissions? You need to clone the `kdelibs` repo from `g...@git.kde.org:kdelibs.git`. Check this in `k

Re: Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103348/#review8762 --- I have an account called shaforo. i could push to kdepimlibs wit

Review Request: optimize kcolorscheme consting time: avoid calculating luma for the same colors multiple times

2011-12-06 Thread Nick Shaforostoff
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103348/ --- Review request for kdelibs. Description --- pretty straightforward an

Re: Review Request: Do not show "Remember Password" checkbox if KWallet is disabled

2011-12-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103291/#review8753 --- Ship it! Ship It! - Aaron J. Seigo On Nov. 29, 2011, 6:48 p.

Re: Review Request: Fix KCategorizedView race

2011-12-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103335/#review8750 --- Ship it! Ship It! - Aaron J. Seigo On Dec. 5, 2011, 2:21 p.m

Re: Review Request: [PATCH] Change HTML thumbnail generator to kdewebkit

2011-12-06 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101365/#review8749 --- Ship it! Ship It! - Aaron J. Seigo On Oct. 23, 2011, 4:19 p.