Review Request: Do not show "Remember Password" checkbox if KWallet is disabled

2011-11-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103291/ --- Review request for KDE Runtime. Description --- The attached patch pr

Review Request: Add git support to kdesdk: create_tarball.rb

2011-11-29 Thread Kåre Särs
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6842/ --- Review request for kdelibs and Release Team. Description --- This patch

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Thomas Lübking
Ok, last observation: The critical value seems to be "13" in Bespin (what means PM_ScrollBarExtent to be "15" for horizontal sliders) The value of qcommonstyle is qMax(16, QApplication::globalStrut()); Cheers, Thomas

Re: Review Request: Proper password caching when opening remote directories in KFileDialog

2011-11-29 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103226/ --- (Updated Nov. 29, 2011, 4:09 p.m.) Review request for kdelibs and David Fa

Re: Review Request: Proper password caching when opening remote directories in KFileDialog

2011-11-29 Thread Dawit Alemayehu
> On Nov. 29, 2011, 10:40 a.m., David Faure wrote: > > kfile/kdirselectdialog.cpp, line 273 > > > > > > Is this really necessary? I thought KIO did this internally already, so > > that when creating a job we could

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Thomas Lübking
Sorry, forgot: raising the value then did expose the issue. I *guess* that kcatergoizedview somewhere blindly copied/borrowed a "random" padding value from Qt/measuring/guessing and simply hardcoded that. Cheers, Thomas

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Thomas Lübking
Am Tue, 29 Nov 2011 09:41:08 +0100 schrieb Jaime : > I just wanted to show you this "nice" view of the mutual recursion. > too deep > recursion.png > Unfortunately, I still have not

Re: Review Request: Proper password caching when opening remote directories in KFileDialog

2011-11-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103226/#review8590 --- kfile/kdirselectdialog.cpp

Re: Review Request: trivial fixes for some warnings of clang++ (2.99.9999)

2011-11-29 Thread Jaime
I just wanted to show you this "nice" view of the mutual recursion. too deep recursion.png Unfortunately, I still have not found the point of exit from it. Any help is wellcome. Best